Pull changes from upstream #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Test JMH command line parsing * Fix JOpt Simple version
…ontrib#1055) * Move compile_java to common code * Implement scrooge_java_library * Add tests * Lint fixes * Lint fixes * sh compatibility * Solve jdk incompatibility * Empty commit to trigger travis * Address some comments * Add test demonstrating worker input mixin * Move mustache and guava to runtime_deps * Change @external:// targets to in-repo deps * Lint fixes * Restore external targets
wisechengyi
approved these changes
Jul 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull some commits from bazelbuild/rules_scala master