Skip to content

make getting expiration better and fix new rustdoc tool lint #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 5, 2021
Merged

make getting expiration better and fix new rustdoc tool lint #40

merged 2 commits into from
Mar 5, 2021

Conversation

Emilgardis
Copy link
Member

No description provided.

Emilgardis
Emilgardis commented Mar 5, 2021
View reviewed changes
Copy link
Member Author

@Emilgardis Emilgardis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors
Copy link
Contributor

bors bot commented Mar 5, 2021

Build failed:

@Emilgardis Emilgardis force-pushed the fixes branch 2 times, most recently from 942569b to 1ebc90e Compare March 5, 2021 22:32
@Emilgardis
Copy link
Member Author

Emilgardis commented Mar 5, 2021 •
edited
Loading

rust-lang/rust#80527

#[allow(unknown_lints)] does not work for this change, need to use renamed_and_removed_lints instead. Allows will be weird for some time I think.

Edit:
Seems this change causes even more trouble. For now I'll make the rustdoc::broken_intra_doc_links nightly only

@Emilgardis
fix lint error
fc8de9f 
also bumps msrv
@Emilgardis Emilgardis changed the title make getting expiration better make getting expiration better and fix new rustdoc tool lint Mar 5, 2021
@Emilgardis
Copy link
Member Author

bors r+

@bors
Copy link
Contributor

bors bot commented Mar 5, 2021

Build succeeded:

@bors bors bot merged commit 0907253 into master Mar 5, 2021
@bors bors bot deleted the fixes branch March 5, 2021 22:54
@Emilgardis Emilgardis mentioned this pull request Mar 5, 2021
Merged
Emilgardis
Emilgardis commented Mar 5, 2021
View reviewed changes
Copy link
Member Author

@Emilgardis Emilgardis left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing expires_in in https://github.com/Emilgardis/twitch_oauth2/blob/0907253396f5aaaaf9db4788fd4170f7ba236c73/src/tokens/app_access_token.rs#L71

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Emilgardis