Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Failure._findFailure dependency on bytecode with some mechanism that doesn't rely on bytecode #12288

Closed
itamarst opened this issue Aug 13, 2024 · 4 comments · Fixed by #12292

Comments

@itamarst
Copy link
Contributor

The problem:

  • As seen in Fix inlineCallbacks tests on Python 3.13 #12061, changes to generated bytecode can break Failure's special inlineCallbacks related code(and quite possibly async functions too).
  • In a world where a CPython JIT is a possibility, it's not clear if any of this will work at all in the future.

It would be better to have a mechanism for finding the current failure that is less tied to obscure implementation details of Python. Perhaps contextvars might do the trick?

@itamarst
Copy link
Contributor Author

😱 that is all

@itamarst
Copy link
Contributor Author

itamarst commented Aug 14, 2024

Notes for the PR:

@glyph
Copy link
Member

glyph commented Aug 14, 2024

@itamarst uhhh; presumably you meant something other than #12016?

@itamarst
Copy link
Contributor Author

Yep, updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants