Merge pull request #18 from twingly/fix/17

Do not allow empty search pattern

Author: twingly-mob

lib/twingly-analytics/query.rb

@@ -25,7 +25,7 @@ def url_parameters
       end
 
       def request_parameters
-        fail("Missing pattern") unless pattern
+        fail("Missing pattern") if pattern.to_s.empty?
 
         {
           :key => client.api_key,

spec/query_spec.rb

@@ -11,6 +11,7 @@
 
   context "without client" do
     subject { Query.new }
+
     it "should not work" do
       expect { subject }.to raise_error(ArgumentError)
     end
@@ -34,8 +35,9 @@
     let(:query) { Query.new(@client) }
 
     context "with valid pattern" do
-      before { allow_any_instance_of(Query).to receive(:pattern).and_return('') }
+      before { query.pattern = "christmas" }
       subject { query.url }
+
       it { should include("xmloutputversion=2") }
     end
 
@@ -44,10 +46,19 @@
         expect { query.url }.to raise_error(RuntimeError, "Missing pattern")
       end
     end
+
+    context "with empty pattern" do
+      before { query.pattern = "" }
+
+      it "raises an error" do
+        expect { query.url }.to raise_error(RuntimeError, "Missing pattern")
+      end
+    end
   end
 
   context "with valid pattern" do
-    before { allow_any_instance_of(Query).to receive(:pattern).and_return('') }
+    before { subject.pattern = "christmas" }
+
     it "should add language" do
       subject.language = "en"
       expect(subject.request_parameters).to include(documentlang: 'en')
@@ -70,8 +81,9 @@
   end
 
   describe "#pattern" do
+    before { subject.pattern = "spotify" }
+
     it "should add searchpattern" do
-      subject.pattern = 'spotify'
       expect(subject.url_parameters).to include("searchpattern=spotify")
     end
   end