Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertical video cut off because remote participant track dimensions coming as 0 on session join. #1470

Closed
piyush2054 opened this issue Mar 4, 2021 · 7 comments
Assignees

Comments

@piyush2054
Copy link

Describe the bug
When a remote participant joins a session from a mobile device (portrait mode) then the video track dimensions come as 0, because of which the isPortrait check always return false and the video track's top and bottom portion gets cut off. If we try to change the orientation of mobile device from portrait to landscape and then again from landscape to portrait then it works fine because the track dimensions come correctly after the track is refreshed.

To Reproduce
Steps to reproduce the behavior:

  1. User 1 Starts a new room from PC/Laptop and act as the observer.
  2. User 2 joins the room created by User1 but from a mobile device (device should be in Portrait Mode)
  3. User 1 can observe that the User 2's video track is showing up in Landscape mode and is cut off from top and bottom.

Expected behavior
Remote participant should send correct track dimensions when the session is joined and VideoTrack is loaded on screen.

Screenshots
vertical video cutoff issue

Environment (please complete the following information):

  • OS: [e.g. Windows 10]
  • Browser: [e.g. Chrome 88.0.4324.190]
  • App Version: [e.g. 0.2.3]
  • SDK Version: [e.g 2.12]
  • Node.js version: [e.g. 15.14.1]
@timmydoza
Copy link
Contributor

Thanks for the detailed bug report @piyush2054!

I can confirm that this bug exists. It appears that the problem lies with the twilio-video.js library. As you describe, it appears that the twilio-video library is not reporting the correct track dimensions until you change the orientation of your device. Because of this, the React app initially does not know that a track has a portrait orientation until you change the orientation to landscape and then back to portrait.

I've created a bug ticket in the backlog of the twilio-video.js library. I'll keep this issue open here so that we can monitor it's progress.

@piyush2054
Copy link
Author

Hi @timmydoza, do we have any update on this issue? This is critical for our the use case for our clients.

@timmydoza
Copy link
Contributor

Hi @piyush2054 - thanks for the comment. I've escalated this issue with the SDK engineers. We will try to have a fix out soon. I'll be sure to update this issue if I hear anything further.

@aaalaniz aaalaniz transferred this issue from twilio/twilio-video-app-react May 10, 2021
@piyush2054
Copy link
Author

Hi @aaalaniz and @timmydoza do we have any update on this issue?

@piyush2054
Copy link
Author

Hi @aaalaniz and @timmydoza do we have any update on this issue? We are holding back on the new updates just to get this issue resolved.

Thanks

@charliesantos
Copy link
Collaborator

@timmydoza @piyush2054 the SDK supports a dimensionsChanged event. Can you listen to this event and update the UI accordingly?

@timmydoza
Copy link
Contributor

Hi @piyush2054 - I'm happy to report that we have fixed this issue in version 2.21.2 of the Twilio Video SDK. You can see the changelog entry here.

I've also released a new version of the React Video App that uses this new SDK version. With this, I'm going to close this issue as it is fixed.

Please let me know if there's anything else that we can help with!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants