Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return value for context.delete always true? #370

Closed
jayschab opened this issue Nov 8, 2017 · 1 comment · Fixed by #462
Closed

Return value for context.delete always true? #370

jayschab opened this issue Nov 8, 2017 · 1 comment · Fixed by #462
Labels
code-generation issue deals with generated code difficulty: easy fix is easy in difficulty type: docs update documentation change not affecting the code type: twilio enhancement feature request on Twilio's roadmap

Comments

@jayschab
Copy link

jayschab commented Nov 8, 2017

Version: 5.4.4

Hi there. I have a question regarding the comments, and consequently, the documentation for all of the instance context.delete calls. Currently the code for all the delete methods are:

  # @return [Boolean] true if delete succeeds, true otherwise
  def delete
    @version.delete('delete', @uri)
  end

I assume the comment/generated docs should read "true if delete succeeds, false otherwise". Can you please confirm?

I discovered this looking at the documentation here

Thanks!

@childish-sambino
Copy link
Contributor

Ha! That's a funny one. You're right that it should be false otherwise. I'll work on a PR.

@childish-sambino childish-sambino added code-generation issue deals with generated code difficulty: easy fix is easy in difficulty status: work in progress Twilio or the community is in the process of implementing type: docs update documentation change not affecting the code type: twilio enhancement feature request on Twilio's roadmap labels Aug 30, 2019
@childish-sambino childish-sambino removed the status: work in progress Twilio or the community is in the process of implementing label Aug 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-generation issue deals with generated code difficulty: easy fix is easy in difficulty type: docs update documentation change not affecting the code type: twilio enhancement feature request on Twilio's roadmap
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants