Ensuring all HTTP connections are properly closed#357
Merged
Conversation
Contributor
|
@nathankurtyka There appears to be a compilation error in your code https://travis-ci.org/twilio/twilio-java/builds/225457155 |
nathankurtyka
force-pushed
the
connection-leak-fix
branch
from
8cafbfa to
9c8b925
Compare
Author
|
@jingming - D'oh.. sorry about that. The branch has been fixed. Let me know if you have any questions! In debugging the leak I had to get somewhat deep into HttpClient, and I'd be happy to save you that time. |
Contributor
|
@nathankurtyka great, thanks for the PR! We will take a look at this further as soon as we can, so please bear with us! |
jingming
approved these changes
May 19, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, and great work on this library!
We've recently discovered an HTTP connection leak can occur under network edge conditions.
This is a pull request that ensures that "... that the entity content has been fully consumed and the underlying stream has been closed" (https://hc.apache.org/httpcomponents-client-4.5.x/tutorial/html/fundamentals.html)
Specifically, the code below reads the full response (while still preserving the code's dependency on accessing the response InputStream), as well as guaranteeing that the response is closed. Both of these steps are important, and are consistent with the HttpClient recommendations.
Let me know if you have any questions! We've been running these modifications in Production for several days now and have not seen the connection leak since.