Skip to content

fix: security vulnerability #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

manisha1997
Copy link
Contributor

Fixes

undici 5.25.4 has vulnerability https://security.snyk.io/package/npm/undici/5.28.4
This will do a forced upgradation to 5.28.5 version.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

"overrides": {
"@actions/core": {
"@actions/http-client": {
"undici": "5.25.5"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to put 5.28.5 over here?

Copy link
Contributor Author

@manisha1997 manisha1997 Jun 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes
This forces npm install to install the version 5.25.5 for undici dependency of http-client of actions/core

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, can we instead use version 5.29.0 which has no direct vulnerabilities?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes This forces npm install to install the version 5.25.5 for undici dependency of http-client of actions/core

Should it be 5.25.5 or 5.28.5? Coz I can see that this vulnerability exists for versions < 5.28.5

Copy link

sonarqubecloud bot commented Jun 4, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants