fix(models): add VanityUrl uses #2257
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
c-model
Member
|
We just tested that, and have found out that |
Contributor
Author
Well, the PR was just to add the uses, would you like me to open another PR for code, or just include that in this one? Modifying the code field is a bit out of scope. |
Member
Yes, another PR fixing this would be ideal. |
Gelbpunkt
approved these changes
Sep 10, 2023
itohatweb
approved these changes
Sep 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The VanityUrl model used for the response from /guilds/{guild.id}/vanity-url is missing the
usesfield.Despite what the aforementioned docs say, the code will not be null if the vanity url is not set, instead, you get a
403response, so I did not make any additional changes beyond adding the uses field.