Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Lavalink NodeConfig fields private #2102

Open
zeylahellyer opened this issue Jan 29, 2023 · 0 comments
Open

Make Lavalink NodeConfig fields private #2102

zeylahellyer opened this issue Jan 29, 2023 · 0 comments
Labels
c-lavalink Affects the lavalink crate m-breaking change Breaks the public API.

Comments

@zeylahellyer
Copy link
Member

The fields of twilight_lavalink::node::NodeConfig are public. We should make them private, because it prevents us doing things like using a wrapper type for the authentication: #2101

This should be done when a refresh of the Lavalink crate is scheduled.
@zeylahellyer zeylahellyer added m-breaking change Breaks the public API. c-lavalink Affects the lavalink crate labels Jan 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c-lavalink Affects the lavalink crate m-breaking change Breaks the public API.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zeylahellyer