Merge pull request #2 from twilight-debugger/twilight-debugger-patch-2

Improvising ideal_gas_law.py

Author: twilight-debugger

physics/ideal_gas_law.py

@@ -1,21 +1,15 @@
 """
-The ideal gas law, also called the general gas equation, is the
-equation of state of a hypothetical ideal gas. It is a good approximation
-of the behavior of many gases under many conditions, although it has
-several limitations. It was first stated by Benoît Paul Émile Clapeyron
-in 1834 as a combination of the empirical Boyle's law, Charles's law,
-Avogadro's law, and Gay-Lussac's law.[1] The ideal gas law is often written
-in an empirical form:
- ------------
- | PV = nRT |
- ------------
-P	=	Pressure (Pa)
-V	=	Volume (m^3)
-n	=	Amount of substance (mol)
-R	=	Universal gas constant
-T	=	Absolute temperature (Kelvin)
-
-(Description adapted from https://en.wikipedia.org/wiki/Ideal_gas_law )
+
+  PV = nRT 
+ 
+Where, P	=	Pressure (Pa)
+       V	=	Volume (m^3)
+       n	=	Amount of substance (mol)
+       R	=	Universal gas constant
+       T	=	Absolute temperature (Kelvin)
+
+Description adapted from https://en.wikipedia.org/wiki/Ideal_gas_law
+
 """
 
 UNIVERSAL_GAS_CONSTANT = 8.314462  # Unit - J mol-1 K-1
@@ -32,9 +26,9 @@ def pressure_of_gas_system(moles: float, kelvin: float, volume: float) -> float:
         ...
     ValueError: Invalid inputs. Enter positive value.
     """
-    if moles < 0 or kelvin < 0 or volume < 0:
+    if moles <= 0 or kelvin <= 0 or volume <= 0:
         raise ValueError("Invalid inputs. Enter positive value.")
-    return moles * kelvin * UNIVERSAL_GAS_CONSTANT / volume
+    return (moles * kelvin * UNIVERSAL_GAS_CONSTANT) / volume
 
 
 def volume_of_gas_system(moles: float, kelvin: float, pressure: float) -> float:
@@ -48,9 +42,9 @@ def volume_of_gas_system(moles: float, kelvin: float, pressure: float) -> float:
         ...
     ValueError: Invalid inputs. Enter positive value.
     """
-    if moles < 0 or kelvin < 0 or pressure < 0:
+    if moles <= 0 or kelvin <= 0 or pressure <= 0:
         raise ValueError("Invalid inputs. Enter positive value.")
-    return moles * kelvin * UNIVERSAL_GAS_CONSTANT / pressure
+    return (moles * kelvin * UNIVERSAL_GAS_CONSTANT) / pressure
 
 
 def temperature_of_gas_system(moles: float, volume: float, pressure: float) -> float:
@@ -64,7 +58,7 @@ def temperature_of_gas_system(moles: float, volume: float, pressure: float) -> f
         ...
     ValueError: Invalid inputs. Enter positive value.
     """
-    if moles < 0 or volume < 0 or pressure < 0:
+    if moles <= 0 or volume <= 0 or pressure <= 0:
         raise ValueError("Invalid inputs. Enter positive value.")
 
     return pressure * volume / (moles * UNIVERSAL_GAS_CONSTANT)
@@ -81,7 +75,7 @@ def moles_of_gas_system(kelvin: float, volume: float, pressure: float) -> float:
         ...
     ValueError: Invalid inputs. Enter positive value.
     """
-    if kelvin < 0 or volume < 0 or pressure < 0:
+    if kelvin <= 0 or volume <= 0 or pressure <= 0:
         raise ValueError("Invalid inputs. Enter positive value.")
 
     return pressure * volume / (kelvin * UNIVERSAL_GAS_CONSTANT)