Optimize batch function and add tests #1007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| </div> | ||
| <div class=row> | ||
| <div class=item>j</div> | ||
| </div> |
There was a problem hiding this comment.
The template is following the twig coding standards.
I couldn't yet find a way to make the template and the code look nice at the same time.
Any suggestions?
There was a problem hiding this comment.
what I mean is that the indentation of the <div class=row> does not look consistent with the way they are written in the template (whereas the table was)
fabpot
added a commit
that referenced
this pull request
Feb 26, 2013
This PR was merged into the master branch. Commits ------- ccf3cd1 optimize batch function and add tests Discussion ---------- Optimize batch function and add tests see fabpot@a50bc8c#commitcomment-2665059
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see fabpot@a50bc8c#commitcomment-2665059