broken escape function with variable parameter

[dellamowica]

Hi, consider this code:

{%set value="ht'ml"%}
{%set tutu='html'%}
{{ value|e(tutu) }}

it's expected to output: ht'ml

but it ouputs ht & # 039;ml

writing this: {{ value|e('html') }} renders the expected output.

Then there seems to be an issue with passing strategies with a variable.

cheers.

[fabpot]

I don't get the issue here? I've just tested and both value|e(tutu) and value|e('html') return the exact same string.

[dellamowica]

There is a problem with quotes, I can reproduce it every time on my install:

{%set strategy='html'%}
{{ "Hél'lö Wôrl'd"|escape(strategy) }}
outputs : Hél'lö Wôrl'd

whereas this:
{{ "Hél'lö Wôrl'd"|escape('html') }}
outputs this: Hél'lö Wôrl'd

in the first example the & character has been encoded where it should not, as though the output was encoded twice.

I'm using twig 1.10.0 with a php5.3.6 install.
Edit: I have tried and reproduced the bug on twig 1.9.2 and 1.10.3

[char101]

You seems to have autoescape on. When the escaping strategy is not a constant (i.e. 'html') the autoescaper will escape the node which will be reescaped by the escape filter.

[dellamowica]

ok thanks, I guess that should be documented, if it's a feature