Skip to content

Conversation

@MohamadSalman11
Copy link
Contributor

Description

I’m not sure if this is an oversight or on purpose, but I think the _isShown() method should be moved to the private section since it’s marked as private, especially since in js/src/dropdown.js it’s correctly placed under the private section. Please let me know if I missed anything. I’d appreciate your feedback!

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@MohamadSalman11 MohamadSalman11 requested a review from a team as a code owner February 10, 2025 11:45
@mdo mdo added this to v5.3.6 Apr 25, 2025
@github-project-automation github-project-automation bot moved this to To do in v5.3.6 Apr 25, 2025
@mdo mdo merged commit 3bb3c95 into twbs:main Apr 25, 2025
14 checks passed
@github-project-automation github-project-automation bot moved this from To do to Done in v5.3.6 Apr 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants