Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: clarify the subject of the About page #40762

Merged
merged 2 commits into from
Sep 4, 2024

Conversation

louismaximepiton
Copy link
Member

@louismaximepiton louismaximepiton commented Aug 22, 2024

Description

Clarify the h1 heading of the page.

Motivation & Context

It'll bring more context for AT users within the page.
After an accessibility audit of our site (based on Bootstrap), just committing the patch upstream.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

Orange-OpenSource/Orange-Boosted-Bootstrap#2667 with issue 4.2.

Copy link

@anandfresh anandfresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@patrickhlauke patrickhlauke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say an about page on a particular project/site is implicitly "about" that project/site, but sure, no harm in being specific

@julien-deramond julien-deramond merged commit 329acbd into main Sep 4, 2024
14 checks passed
@julien-deramond julien-deramond deleted the main-lmp-clarify-about-title branch September 4, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants