Skip to content

Conversation

@julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented May 29, 2024

Description

This PR adds the missing data-bs-theme="light" data attribute in the last example of the navbars color schemes at https://getbootstrap.com/docs/5.3/components/navbar/#color-schemes.

The executed code contained it, but not the copyable markup.

Type of changes

  • Documentation fix (non-breaking change which fixes an issue)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • (N/A) I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

Discussed in #39989 (comment)

Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@julien-deramond julien-deramond merged commit d6731ea into main May 29, 2024
@julien-deramond julien-deramond deleted the main-jd-missing-data-bs-theme-light-in-navbars branch May 29, 2024 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants