Skip to content

Conversation

@XhmikosR
Copy link
Member

@XhmikosR XhmikosR commented Mar 22, 2024

The dimensions must be of the non-2x image.

Description

Motivation & Context

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues


TODO:

  • optimize the images but look out for color changes

@XhmikosR XhmikosR force-pushed the xmr/docs-bundler-images branch from fe19114 to 597eb28 Compare March 22, 2024 07:30
The dimensions must be of the non-2x image.
@XhmikosR XhmikosR force-pushed the xmr/docs-bundler-images branch from af8a2bb to 8fe1b27 Compare March 22, 2024 07:44
@XhmikosR XhmikosR force-pushed the xmr/docs-bundler-images branch from 8fe1b27 to 6c6522a Compare March 22, 2024 07:47
@XhmikosR XhmikosR marked this pull request as ready for review March 22, 2024 14:41
@XhmikosR XhmikosR requested a review from mdo March 22, 2024 14:41
@XhmikosR XhmikosR merged commit ba73ed6 into main Apr 1, 2024
@XhmikosR XhmikosR deleted the xmr/docs-bundler-images branch April 1, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants