minLength option

[pnovodvorskiy]

Added option to only start querying only after user has entered a minimum number of characters

[fat]

this looks ok - but doesn't merge. can you update your request? thanks!

[mckramer]

What about combining the check with the next one?
From:

if (this.$element.val().length < this.minLength) {
  return this.shown ? this.hide() : this
}   
this.query = this.$element.val()    
if (!this.query) {
 return this.shown ? this.hide() : this
}

To:

this.query = this.$element.val()
if (!this.query || this.query.length < this.minLength) {
  return this.shown ? this.hide() : this
}

Otherwise, I think it would be a welcome change, especially since 2.1 will be able to handle async lookups. So, you could limit the number of calls.

[richardp-au]

Does the data attribute for this need a capital L? If so, perhaps we could make it lowercase instead or even choose a different name. The capital would not only look a bit ugly but would confuse a lot of people and result in dozens of false bug reports.

[travisbot]

This pull request passes (merged 8017777 into fb29075).

[pnovodvorskiy]

I merged the latest code from 2.1.0-wip and combined the 2 checks. I used the camel case for the naming and that's why the capital L.

[richardp-au]

I understand why you used camel case but how does this affect the data attribute?

[pnovodvorskiy]

What would you prefer? min-length?

[richardp-au]

Refer to: http://blog.benpowell.co.uk/2012/03/warning-html5-data-attribute-is-case.html

So basically, HTML5 data attributes must be all lowercase and they automatically map hyphen characters (-) to camel case in the data list.

This means that in your case data-max-length is the data attribute that maps to maxLength in the JavaScript. So based on that I see no problem with what you've got.

I guess this should be noted in the docs and then it's up to @fat whether he's happy to have the two slightly differing names or whether he thinks it might confuse people too much.

[pnovodvorskiy]

Thanks for the clarification. I'll wait then to see if it's accepted.

[fat]

gah - super sorry, there was a bug in the unit test detection script i just ran.

[fat]

can you remove the spaces here? thanks!

[fat]

just went ahead and implemented it. thanks!