CSS: new $navbar-*
aliases for $navbar-light-*
Sass vars
#39441
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When we developed the color modes, we chose to keep
$navbar-light-*
Sass variables to avoid breaking changes even if it was obvious that the naming wasn't correct;$navbar-light-*
setting the values for both light and dark modes.This PR is an attempt to find a non-breaking solution to close #39070 before having to wait for a v6 to introduce corresponding
$navbar-*
Sass variables (without the-light-
keyword).The idea here is to introduce exactly the same Sass variables without the
-light-
keyword.Each of these new variables would have the corresponding
$navbar-light-*
Sass variables as default values.However, some
$navbar-light-*
Sass variables depended on each other, so it makes it a little bit more difficult.If we consider existing projects, overriding one or more
$navbar-light-*
Sass variables should give exactly the same result. But overriding the new$navbar-*
should also work.So far, I haven't found another solution than the one suggested in this PR.
If it's completely non-breaking, I'd suggest introducing it directly in a v5.3.x because it was something missing in the v5.3 color modes feature.
@twbs/css-review thoughts?
Motivation & Context
Provide as soon as possible the right naming for Navbar Sass variables for consistency of usage.
Type of changes
Checklist
npm run lint
)Live previews
Related issues
Closes #39070