-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow dl, dt and dd in sanitizer #39376
Conversation
These are inoffensive regular elements, along the same lines as ol/ul with li.
Can't think of any reason to not include them. Thoughts @XhmikosR @GeoSot? Or @julien-deramond? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving conditionally while waiting on feedback.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, can't think of a reason to not include them.
I've found this draft W3C Standard Proposal > HTML Sanitizer API where there's a section named The Baseline Element Allow List. These elements are mentioned in it too.
Co-authored-by: Julien Déramond <juderamond@gmail.com>
Motivation & Context
These are inoffensive regular elements, along the same lines as ol/ul with li. Overriding the defaults for that seems silly.
Type of changes
(I guess it's somewhere in the middle.)
Checklist
npm run lint
)Live previews
Related issues
#33827