-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor css: modal and offcanvas header spacing #39373
Conversation
17075a6
to
9a909bf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff!
9a909bf
to
19b9f6b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @MarkoOleksiyenko! Neat!
Thanks for the review @mdo and @julien-deramond ! |
If you use the dark variant of the "close" button as show here; |
@Batman08 you should create a new issue |
Description
PR regarding the discussion https://github.com/orgs/twbs/discussions/39370 about the spacing in the modal (plus offcanvas) header. The space-between is not used anymore as the position of the btn-close is based on the margin now.
Motivation & Context
If the btn-close is removed the content is distributed evenly (space-between behavior), so the wide modals have scattered title if the header is composite (e.g. icon plus text). It is logical to put it to the default setting, which is justify-content: start.
Type of changes
(not sure whether it is breaking change, but might be, please correct me if I am wrong)
Checklist
npm run lint
)Live previews
Related GH discussion
https://github.com/orgs/twbs/discussions/39370