-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: fix carousel carousel colors of carousel examples in dark mode #38840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdo
approved these changes
Jul 17, 2023
This was referenced May 19, 2024
This was referenced May 24, 2024
This was referenced May 24, 2024
This was referenced May 24, 2024
This was referenced Sep 18, 2024
This was referenced Sep 28, 2024
This was referenced Sep 30, 2024
This was referenced Oct 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the unnecessary
data-bs-theme="light"
from the carousel markup in both the LTR and RTL carousel examples.Motivation & Context
The rendering in dark mode was not working properly because of the
data-bs-theme="light"
attribute:Please double-check that the rendering in dark mode is considered as fitting the global design.
Type of changes
Checklist
npm run lint
)Live previews
Please test these URLs in light and dark mode: