-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tables: add a fix to handle .bg-*
and .text-*
utilities on tables.
#38826
Open
louismaximepiton
wants to merge
10
commits into
main
Choose a base branch
from
main-lmp-table-fix-unwanted-changes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
Any plans on merging this pull requests? These were indeed breaking changes. Not only on background colors of tables but font colors too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Set the background and color on the table itself so it avoids nesting. Added for every cell a cascade if the
--bs-table-color/bg
is redefined. If not, every cell inherits the table color/bg.Please double-check that :
.table-hover
,.table-active
, etc... still workinherit
to make things working using.text-bg-primary
for example.Motivation & Context
Many issues and discussions about the fact that the utilities used to work and weren't working anymore on table at every level.
Type of changes
Checklist
npm run lint
)Live previews
Related discussions
#38727
#38730
#38690
#38744
#39812
https://github.com/orgs/twbs/discussions/40747
Related issues
Closes #38779