Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add color-modes.js to bootstrap-x.y.z-examples.zip #38747

Merged
merged 1 commit into from
Jun 18, 2023
Merged

Add color-modes.js to bootstrap-x.y.z-examples.zip #38747

merged 1 commit into from
Jun 18, 2023

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Jun 12, 2023 •
edited
Loading

Description

As described in #38746, new color-modes.js asset was not including in bootstrap-x.y.z-examples.zip.
This PR modifies build/zip-examples.js which is used to create the corresponding directory.

/cc @XhmikosR for a possible v5.3.1

How to test

Locally:

$ npm run release
$ unzip bootstrap-5.3.0-examples.zip
$ php -S localhost:800 # Or run another local server

Then go to http://localhost:8008/album and change the color mode

Type of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

Related issues

Closes #38746

@julien-deramond julien-deramond requested a review from a team as a code owner June 12, 2023 10:46
@julien-deramond julien-deramond force-pushed the main-jd-add-color-modes-to-examples-zip branch from 423b977 to 8ff9364 Compare June 12, 2023 10:48
@julien-deramond julien-deramond mentioned this pull request Jun 12, 2023
Closed
2 tasks
@XhmikosR XhmikosR merged commit 5036f70 into main Jun 18, 2023
@XhmikosR XhmikosR deleted the main-jd-add-color-modes-to-examples-zip branch June 18, 2023 14:52
@XhmikosR XhmikosR added the build label Jul 26, 2023
romankupchak93 pushed a commit to romankupchak93/bootstrap that referenced this pull request Jan 5, 2024
@julien-deramond @romankupchak93
Add color-modes.js to bootstrap-x.y.z-examples.zip (twbs#38747)
6cba4ed
@lukegeor lukegeor mentioned this pull request May 18, 2024
Open
This was referenced May 19, 2024
Open
Open
@Hamberfim Hamberfim mentioned this pull request May 21, 2024
Merged
@V1CTORY360 V1CTORY360 mentioned this pull request May 22, 2024
Open
This was referenced May 24, 2024
Open
Open
@devcurt696 devcurt696 mentioned this pull request May 24, 2024
Open
@suryaelidanto suryaelidanto mentioned this pull request May 24, 2024
Open
@nejidevelops nejidevelops mentioned this pull request May 24, 2024
Open
@Guiguiiz92 Guiguiiz92 mentioned this pull request May 24, 2024
Open
@Cpano Cpano mentioned this pull request May 24, 2024
Open
@zxcv32 zxcv32 mentioned this pull request May 24, 2024
Open
@rawanst rawanst mentioned this pull request May 24, 2024
Open
@V1CTORY360 V1CTORY360 mentioned this pull request May 24, 2024
Open
This was referenced May 24, 2024
Open
Open
@ngochoangg ngochoangg mentioned this pull request May 24, 2024
Open
@jadsongmatos jadsongmatos mentioned this pull request May 24, 2024
Open
@RodolfoBorbon RodolfoBorbon mentioned this pull request Sep 9, 2024
Open
@csmartinez22 csmartinez22 mentioned this pull request Sep 9, 2024
Open
@lucasaugustodeveloper lucasaugustodeveloper mentioned this pull request Sep 9, 2024
Open
@WontonSam WontonSam mentioned this pull request Sep 10, 2024
Open
@RodolfoBorbon RodolfoBorbon mentioned this pull request Sep 13, 2024
Open
@lucasaugustodeveloper lucasaugustodeveloper mentioned this pull request Sep 13, 2024
Open
@csmartinez22 csmartinez22 mentioned this pull request Sep 14, 2024
Open
This was referenced Sep 17, 2024
Open
Open
@AndresElacion AndresElacion mentioned this pull request Sep 24, 2024
Open
@castle2668 castle2668 mentioned this pull request Sep 24, 2024
Merged
This was referenced Sep 25, 2024
Open
Open
Open
@pinco227 pinco227 mentioned this pull request Sep 27, 2024
Open
This was referenced Sep 28, 2024
Open
Open
@lisagorewitdecker lisagorewitdecker mentioned this pull request Sep 30, 2024
Merged
This was referenced Sep 30, 2024
Open
Open
@Akhamesra Akhamesra mentioned this pull request Oct 2, 2024
Open
@YnnusAsamal YnnusAsamal mentioned this pull request Oct 3, 2024
Open
@jtprogru jtprogru mentioned this pull request Oct 5, 2024
Open
@Gutts-n Gutts-n mentioned this pull request Oct 5, 2024
Open
@Kimahari Kimahari mentioned this pull request Oct 5, 2024
Open
This was referenced Oct 12, 2024
Open
Open
Open
Open
@Arrhenius09 Arrhenius09 mentioned this pull request Nov 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XhmikosR XhmikosR XhmikosR approved these changes

Assignees
No one assigned
Labels
build color mode v5
Projects
No open projects
v5.3.1
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Examples download "bootstrap-5.3.0-examples.zip" is missing file for dark mode "color-modes.js"
2 participants
@julien-deramond @XhmikosR