add a thanks page to our doc #28744

Johann-S · 2019-05-08T13:01:58Z

Live previews

MartijnCuppens · 2019-05-08T18:24:43Z

Changed the theming a bit and did some copy changes.

site/content/docs/4.3/thanks.md

Johann-S · 2019-06-03T13:16:37Z

Hi @znarf do you know when this endpoint: https://opencollective.com/bootstrap/members/all.json?TierId=7192 will have CORS too ?

znarf · 2019-06-03T21:24:42Z

@Johann-S https://opencollective.com/api/groups/bootstrap/backers is not documented and deprecated, this should not be used. We're trying to get rid of it. opencollective/opencollective#2037

I now recommend to start using the GraphQL API v2 for everything. https://medium.com/open-collective/open-collective-graphql-api-preview-3b42ed1d55ff

If what you need is a REST endpoint with CORS, let me know exactly the required data and I'll try to make that available.

Johann-S · 2019-06-05T08:08:43Z

Hi @znarf,

Thanks for letting me know that 👍 but we need a REST endpoint with CORS, we don't have a backend server which will fetch the OC data for us 😟 I would love using your GraphQL but it would expose our API key publicly

znarf · 2019-06-05T08:50:11Z

Like I said:

If what you need is a REST endpoint with CORS, let me know exactly the required data and I'll try to make that available.

What the endpoint should be and which data should it returns? And on your side, which fields are you reading from?

Johann-S · 2019-06-05T11:17:35Z

The end point should be this one: https://opencollective.com/bootstrap/members/all.json with CORS and should accept a TierId query param to let us filter by tier id.

The data we need for our Backers and Sponsors:

Name
Image
Website
IsActive
TotalAmountDonated
TierId

znarf · 2019-06-07T14:45:39Z

What do you think of that? https://rest.opencollective.com/v2/bootstrap/orders/incoming/active

It's featuring all active subscriptions, has CORS and all the fields you need. Only tierId is not available, better use tier.slug instead.

Johann-S · 2019-06-07T14:51:13Z

Thanks @znarf ! That's awesome 👍

I saw we can use this one too: https://rest.opencollective.com/v2/bootstrap/orders/incoming
To get all the people who supported us

znarf · 2019-06-07T15:50:29Z

@Johann-S maybe you want then to filter the ones with status=ERROR (payment failed) and status=PENDING (payment waiting for confirmation).

Johann-S · 2019-06-07T16:22:56Z

I don't think it's usefull for us 🤔 what you provided to us is perfect 👍

site/content/docs/4.3/thanks.md

Johann-S · 2019-06-11T07:48:42Z

Pushed a commit where we use the new API (thanks @znarf)~~, we have a small CSS issue with backers images~~

patrickhlauke · 2021-05-04T11:46:12Z

Is this still relevant?

XhmikosR · 2021-05-04T12:56:26Z

Yeah, it's relevant although probably not like it is right now. We still need to add sponsors in the homepage later.

github-actions · 2022-12-09T07:51:28Z

Images automagically compressed by Calibre's image-actions ✨

Compression reduced images by 16.4%, saving 84.00 KB.

Filename	Before	After	Improvement	Visual comparison
`site/static/docs/5.2/assets/img/bootstrap-sponsoring.png`	256.55 KB	214.55 KB	-16.4%	View diff
`site/static/docs/5.2/assets/img/bootstrap-sponsoring@2x.png`	256.55 KB	214.55 KB	-16.4%	View diff

105 images did not require optimisation.

Update required: Update image-actions configuration to the latest version before 1/1/21. See README for instructions.

julien-deramond · 2022-12-09T07:53:42Z

Tried something in dbc7287 to also add a new section in our homepage. Done very quickly but you get the spirit 😇

/cc @mdo

louismaximepiton

Might need an update of the assets to migrate to v5.3 and update the markup to adopt some new helpers we have

louismaximepiton · 2023-06-27T12:16:56Z

site/static/docs/5.2/assets/img/bootstrap-sponsoring.png

This one look exactly the same as the one @2x, is that fine ?

Yes, it should be changed whenever this PR is finalized. Let's keep this conversation opened to not forget it :)

site/layouts/partials/home/sponsoring.html

louismaximepiton · 2023-06-27T12:32:59Z

site/layouts/partials/home/sponsoring.html

@@ -0,0 +1,23 @@
+<section class="row g-3 g-md-5 pb-md-5 mb-5 align-items-center">
+  <div class="col-lg-6">
+    <div class="masthead-followup-icon d-inline-block mb-3" style="--bg-rgb: var(--bd-violet-rgb);">


Don't we have any other color in here ? It looks like duplicate of the previous one

We already use danger, info, pink, primary, violet, teal, warning, violet on this page. The remaining colors in the palette are too close to the used one (green almost like teal, cyan like info, indigo like violet) so I'm not sure how to choose another one. @mdo could help us if we try to finalize this PR.

louismaximepiton · 2023-06-27T12:45:33Z

site/content/docs/5.2/about/support-bootstrap.md

+## Sponsors
+
+{{< sponsors.inline >}}
+<div id="sponsorList" class="d-flex flex-wrap mx-n2 text-center"></div>


Unless I'm wrong, Bootstrap doesn't provide negative margins in here so the rendering looks a bit shifted.

Yep, you're right, it was added in the first commits from this PR in 4c7953d. I'll check how to change the rendering.

Enhancement of the rendering done via d5b5c3b. Maybe there's a better solution, but this quick one should allow to resolve this thread.

site/content/docs/5.2/about/support-bootstrap.md

julien-deramond · 2024-02-27T16:48:40Z

If having a new homepage section to support Bootstrap is still a thing, I could extract this independent part from this PR so that it can be tackled probably more rapidly, while we take our time for the pure sponsors page to find the right technical solution.

Thoughts? (/cc @mdo)

louismaximepiton

The rendering looks reaaly good, well done! Some minor changes before merging and we're good to go on my side.

louismaximepiton · 2024-02-29T10:13:17Z

site/content/docs/5.3/about/support-bootstrap.md

+      {{ if .website -}}
+        <a href="{{ .website }}" class="stretched-link text-reset" title="{{ .name }}" target="_blank" rel="nofollow noopener noreferrer">
+      {{ end -}}
+      <img src="{{ printf ("/docs/%s/assets/img/services/%s") $.Site.Params.docs_version .image }}" alt="{{ .name }}" class="mh-100 mw-100">


Since they are static images, we have an issue with dark mode, maybe add a static background to its parent or use the svg directly (this way we can color the text using var(--bs-body-color) or something similar) ?

louismaximepiton · 2024-02-29T10:14:54Z

site/content/docs/5.3/about/support-bootstrap.md

+          )
+        }
+
+        output.push(`<img src="${backerAccount.imageUrl}" alt="${backerAccount.name}" class="img-fluid d-block">`)


To have at least the backer's pseudo displayed somehow

Suggested change

output.push(`<img src="${backerAccount.imageUrl}" alt="${backerAccount.name}" class="img-fluid d-block">`)

output.push(`<img src="${backerAccount.imageUrl}" title="${backerAccount.name}" alt="${backerAccount.name}" class="img-fluid d-block">`)

louismaximepiton · 2024-02-29T10:16:09Z

site/content/docs/5.3/about/support-bootstrap.md

+        output.push(
+          '<div class="position-relative">',
+          ' <div class="img-thumbnail mx-auto d-flex align-items-center justify-content-center overflow-hidden sponsor">',
+          `  <img class="img-fluid d-block" src="${sponsorAccount.imageUrl}" alt="${sponsorAccount.name}">`,


Suggested change

` <img class="img-fluid d-block" src="${sponsorAccount.imageUrl}" alt="${sponsorAccount.name}">`,

` <img class="img-fluid d-block" src="${sponsorAccount.imageUrl}" title="${sponsorAccount.name}" alt="${sponsorAccount.name}">`,

louismaximepiton · 2024-02-29T10:17:36Z

site/content/docs/5.3/about/support-bootstrap.md

+        )
+
+        if (sponsorAccount.website) {
+          output.push(`<a href="${sponsorAccount.website}" class="stretched-link text-reset" title="${sponsorAccount.name}" target="_blank" rel="nofollow noopener noreferrer">${sponsorAccount.name}</a>`)


Suggested change

output.push(`<a href="${sponsorAccount.website}" class="stretched-link text-reset" title="${sponsorAccount.name}" target="_blank" rel="nofollow noopener noreferrer">${sponsorAccount.name}</a>`)

output.push(`<a href="${sponsorAccount.website}" class="stretched-link text-reset" target="_blank" rel="nofollow noopener noreferrer">${sponsorAccount.name}</a>`)

louismaximepiton · 2024-02-29T10:20:19Z

site/content/docs/5.3/about/support-bootstrap.md

+    })()
+  })()
+</script>
+{{< /services.inline >}}


Feels wrong to have this closing tag after the script one

louismaximepiton · 2024-02-29T10:26:18Z

site/layouts/partials/home/sponsoring.html

+    </p>
+  </div>
+  <div class="col-lg-6">
+      <img class="img-fluid mt-3 mx-auto" srcset="/docs/{{ .Site.Params.docs_version }}/assets/img/bootstrap-sponsoring.png,


Better fit with general spirit of the page in dark mode imo

Suggested change

<img class="img-fluid mt-3 mx-auto" srcset="/docs/{{ .Site.Params.docs_version }}/assets/img/bootstrap-sponsoring.png,

<img class="img-fluid mt-3 mx-auto rounded" srcset="/docs/{{ .Site.Params.docs_version }}/assets/img/bootstrap-sponsoring.png,

louismaximepiton · 2024-02-29T10:30:51Z

site/content/docs/5.3/about/support-bootstrap.md

Shouldn't we add a section with best or last donators in here ?

Johann-S added the docs label May 8, 2019

XhmikosR force-pushed the jo-docs-thanks-page branch 2 times, most recently from 5144138 to 2161ae9 Compare May 8, 2019 13:52

XhmikosR reviewed May 8, 2019

View reviewed changes

site/content/docs/4.3/thanks.md Outdated Show resolved Hide resolved

XhmikosR reviewed May 8, 2019

View reviewed changes

site/content/docs/4.3/thanks.md Outdated Show resolved Hide resolved

XhmikosR reviewed May 8, 2019

View reviewed changes

site/content/docs/4.3/thanks.md Outdated Show resolved Hide resolved

XhmikosR force-pushed the jo-docs-thanks-page branch from 041e4bc to b8f5029 Compare May 21, 2019 10:06

Johann-S mentioned this pull request Jun 3, 2019

[API] Return internal error opencollective/opencollective#2082

Closed

Johann-S force-pushed the jo-docs-thanks-page branch 2 times, most recently from f9c564a to 08ac306 Compare June 3, 2019 13:02

Johann-S force-pushed the jo-docs-thanks-page branch 2 times, most recently from fabb694 to a3c807b Compare June 3, 2019 14:43

XhmikosR reviewed Jun 8, 2019

View reviewed changes

site/content/docs/4.3/thanks.md Outdated Show resolved Hide resolved

XhmikosR reviewed Jun 8, 2019

View reviewed changes

site/content/docs/4.3/thanks.md Outdated Show resolved Hide resolved

XhmikosR force-pushed the jo-docs-thanks-page branch 2 times, most recently from b3f87d9 to e434915 Compare June 8, 2019 11:55

Johann-S force-pushed the jo-docs-thanks-page branch from 6453920 to 5f7f894 Compare June 11, 2019 07:54

XhmikosR force-pushed the jo-docs-thanks-page branch from 38bb026 to 91a20e7 Compare July 10, 2019 08:14

Johann-S and others added 6 commits December 2, 2020 20:43

change opencollective endpoint to get backers

b72135b

Tweak image.

9f72bba

Clean up classes and lint JS.

9febb30

migrate to new oc api

e46e225

Move inline css to scss file

0580673

Fix TypeError

abc3a67

XhmikosR force-pushed the jo-docs-thanks-page branch from b5d9034 to abc3a67 Compare December 2, 2020 18:50

XhmikosR and others added 4 commits December 2, 2020 21:00

Updates

a564685

Add name

6551bff

Merge branch 'main' into jo-docs-thanks-page

018ee6a

Merge branch 'main' into jo-docs-thanks-page

8865a8a

Merge branch 'main' into jo-docs-thanks-page

37f5fee

julien-deramond added the v5 label Dec 8, 2022

julien-deramond and others added 4 commits December 8, 2022 21:53

Update branch to work with 5.2

6edd51a

Move page into About and add a description

b80aa56

Add new section in the homepage

dbc7287

Optimised images with calibre/image-actions

57dc3ff

Merge branch 'main' into jo-docs-thanks-page

de44298

louismaximepiton reviewed Jun 27, 2023

View reviewed changes

julien-deramond added 5 commits February 25, 2024 09:09

Merge branch 'main' into jo-docs-thanks-page

d57006a

Update to 5.3 directory

8f160fc

Fix use of backticks in support-bootstrap.md

9f78df1

Update sponsoring.html based on latest masthead modifications

0ad4af9

Get rid of .mx-n* classes

d5b5c3b

louismaximepiton requested changes Feb 29, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add a thanks page to our doc #28744

add a thanks page to our doc #28744

Johann-S commented May 8, 2019 •

edited by julien-deramond

Loading

MartijnCuppens commented May 8, 2019

Johann-S commented Jun 3, 2019

znarf commented Jun 3, 2019

Johann-S commented Jun 5, 2019

znarf commented Jun 5, 2019 •

edited

Loading

Johann-S commented Jun 5, 2019

znarf commented Jun 7, 2019

Johann-S commented Jun 7, 2019

znarf commented Jun 7, 2019

Johann-S commented Jun 7, 2019

Johann-S commented Jun 11, 2019 •

edited

Loading

patrickhlauke commented May 4, 2021

XhmikosR commented May 4, 2021

github-actions bot commented Dec 9, 2022

julien-deramond commented Dec 9, 2022 •

edited

Loading

louismaximepiton left a comment

louismaximepiton Jun 27, 2023

julien-deramond Feb 25, 2024

louismaximepiton Jun 27, 2023

julien-deramond Feb 25, 2024

louismaximepiton Jun 27, 2023

julien-deramond Feb 25, 2024

julien-deramond Feb 27, 2024

julien-deramond commented Feb 27, 2024

louismaximepiton left a comment

louismaximepiton Feb 29, 2024

louismaximepiton Feb 29, 2024

louismaximepiton Feb 29, 2024

louismaximepiton Feb 29, 2024

louismaximepiton Feb 29, 2024

louismaximepiton Feb 29, 2024

louismaximepiton Feb 29, 2024

	output.push(`<img src="${backerAccount.imageUrl}" alt="${backerAccount.name}" class="img-fluid d-block">`)
	output.push(`<img src="${backerAccount.imageUrl}" title="${backerAccount.name}" alt="${backerAccount.name}" class="img-fluid d-block">`)

	` <img class="img-fluid d-block" src="${sponsorAccount.imageUrl}" alt="${sponsorAccount.name}">`,
	` <img class="img-fluid d-block" src="${sponsorAccount.imageUrl}" title="${sponsorAccount.name}" alt="${sponsorAccount.name}">`,

	output.push(`<a href="${sponsorAccount.website}" class="stretched-link text-reset" title="${sponsorAccount.name}" target="_blank" rel="nofollow noopener noreferrer">${sponsorAccount.name}</a>`)
	output.push(`<a href="${sponsorAccount.website}" class="stretched-link text-reset" target="_blank" rel="nofollow noopener noreferrer">${sponsorAccount.name}</a>`)

	<img class="img-fluid mt-3 mx-auto" srcset="/docs/{{ .Site.Params.docs_version }}/assets/img/bootstrap-sponsoring.png,
	<img class="img-fluid mt-3 mx-auto rounded" srcset="/docs/{{ .Site.Params.docs_version }}/assets/img/bootstrap-sponsoring.png,

add a thanks page to our doc #28744

Are you sure you want to change the base?

add a thanks page to our doc #28744

Conversation

Johann-S commented May 8, 2019 • edited by julien-deramond Loading

Live previews

MartijnCuppens commented May 8, 2019

Johann-S commented Jun 3, 2019

znarf commented Jun 3, 2019

Johann-S commented Jun 5, 2019

znarf commented Jun 5, 2019 • edited Loading

Johann-S commented Jun 5, 2019

znarf commented Jun 7, 2019

Johann-S commented Jun 7, 2019

znarf commented Jun 7, 2019

Johann-S commented Jun 7, 2019

Johann-S commented Jun 11, 2019 • edited Loading

patrickhlauke commented May 4, 2021

XhmikosR commented May 4, 2021

github-actions bot commented Dec 9, 2022

julien-deramond commented Dec 9, 2022 • edited Loading

louismaximepiton left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

julien-deramond commented Feb 27, 2024

louismaximepiton left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Johann-S commented May 8, 2019 •

edited by julien-deramond

Loading

znarf commented Jun 5, 2019 •

edited

Loading

Johann-S commented Jun 11, 2019 •

edited

Loading

julien-deramond commented Dec 9, 2022 •

edited

Loading