Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed color treatment of outline for easier integration #11551

Merged
merged 1 commit into from
Nov 28, 2013
Merged

removed color treatment of outline for easier integration #11551

merged 1 commit into from
Nov 28, 2013

Conversation

masterbee
Copy link
Contributor

  • The default outline treatment of outline is invert which ensures that the outline colour will always have sufficient contrast from the background it is on.
  • .tab-focus() mixin was styling the background colour to #333 , this poses a bit of a restriction for implementers of twitter bootstrap since if the background is darker than white, there may not be enough contrast to see the outline, causing an accessibility issue.

Great work again TB team, looking forward to v3.0.3

/cc @mdo @cvrebert

@cvrebert
Copy link
Collaborator

I have no opinion personally, but I am going to point out that I've seen complaints from some perfectionists who find the default dotted outlines ugly; the special WebKit styling throws them a bone in that regard.

@masterbee
Copy link
Contributor Author

@cvrebert - Thanks for chime in, and I am all for throwing a bone when we can, but since outline is one of those areas branded by accessibility [http://www.w3.org/TR/WCAG-TECHS/F78.html], styling colour in that property maybe a slippery slope, when natively browsers are already doing it for you safely, IMHO.

Keep up the great work guys 👍

@mdo
Copy link
Member

mdo commented Nov 20, 2013

I don't think I want to remove the WebKit outline, but I can get behind removing the color from the default outline.

@masterbee
Copy link
Contributor Author

@mdo , thanks for the response. will update my PR to address.

@masterbee
Copy link
Contributor Author

@mdo , @cvrebert I will be tweaking this in a few moments. Sorry about the delay

Thank you again.

@masterbee
Copy link
Contributor Author

@cvrebert , @mdo - PR updated.

@cvrebert
Copy link
Collaborator

@masterbee Could you squash this into a single commit? If not, I can, when @mdo gives the go-ahead.

@masterbee
Copy link
Contributor Author

@cvrebert - all set thanks for the patience.

mdo added a commit that referenced this pull request Nov 28, 2013
removed color treatment of outline for easier integration
@mdo mdo merged commit ec9d470 into twbs:master Nov 28, 2013
@mdo mdo mentioned this pull request Nov 28, 2013
@masterbee masterbee deleted the outlinetweak branch November 30, 2013 18:07
pytkin added a commit to designmodo/Flat-UI that referenced this pull request Feb 5, 2014
stempler pushed a commit to stempler/bootstrap that referenced this pull request Apr 11, 2014
removed color treatment of outline for easier integration
stempler pushed a commit to stempler/bootstrap that referenced this pull request Nov 4, 2014
removed color treatment of outline for easier integration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants