-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Floating Label: position is not correctly aligned #40734
Comments
PS: the examples and code only show the select-input, but this issue effects ALL floating-labels. |
The PR #40735 fixes the issue of alignment of floating labels as mentioned by the author of this issue. The said change is done in the _variable.scss file by creating 3 new variables for padding-top, padding-bottom, and font-size which are injected in the forms/_floating-labels.scss file. @Alken0, you can have a look too here. Kindly merge this PR as soon as possible. |
fixed in #40735 |
@poswalsameer thank you very much for your work |
Thanks a lot! |
Hi @julien-deramond, I have created a PR that solves the said issue, can you please review it and let me know if further changes are required? Thank You! |
Prerequisites
Describe the issue
I saw that the labels of Floating-Label are not perfectly aligned while first messing around with incorrect ellipsis on 5.3 (which has ben fixed according to other issues).
This is a screenshot of the website of version 5.2 (to have a correct version):
I would suggest a change to display the label with a better alignmend to the sides:
Reduced test cases
The problem, why this occurs is in the following css-attribute:
The scale factor reduces the size that was 100% before the transform.
Therefore the real width is 100%*0.85 instead of 100%.
In addition, the alignment is not perfect regarding the left-side because of translateX and translateY.
I would suggest the following change:
Thank you for your work!
What operating system(s) are you seeing the problem on?
Windows
What browser(s) are you seeing the problem on?
Chrome
What version of Bootstrap are you using?
v5.2 (not tested on 5.3)
The text was updated successfully, but these errors were encountered: