Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugs inside "Cover Template" and "Product Template" #39656

Closed
3 tasks done
gipic opened this issue Feb 7, 2024 · 1 comment · Fixed by #39657
Closed
3 tasks done

Bugs inside "Cover Template" and "Product Template" #39656

gipic opened this issue Feb 7, 2024 · 1 comment · Fixed by #39657

Comments

@gipic
Copy link

gipic commented Feb 7, 2024

Prerequisites

Describe the issue

There are two small bugs inside these webpages published on bootstrap v 5.3

  • "Cover template": light-dark toogle does not work
  • "Product example": when screen is small (mobile for example), menu does not work. I click the button but nothing happens.

I am new to bootstrap and I was looking to some examples for the first time.
I am unable to solve these small bugs.
Thank you very much.

Reduced test cases

https://getbootstrap.com/docs/5.3/examples/cover/

https://getbootstrap.com/docs/5.3/examples/product/

What operating system(s) are you seeing the problem on?

Windows

What browser(s) are you seeing the problem on?

Chrome, Firefox

What version of Bootstrap are you using?

5.3

@gipic gipic changed the title Buds inside "Cover Template" and "Prodcut Template" Buds inside "Cover Template" and "Product Template" Feb 7, 2024
@gipic gipic changed the title Buds inside "Cover Template" and "Product Template" Bugs inside "Cover Template" and "Product Template" Feb 7, 2024
@julien-deramond
Copy link
Member

julien-deramond commented Feb 7, 2024

Thanks for reporting this double-issue @gipic

"Cover template": light-dark toogle does not work

This example was created to be always dark. The theme selector well changes the data-bs-theme to "light" and "dark" values. However, this example uses all the time .text-bg-dark to define the background as dark in all cases. So this is not an issue but something created to work like this.
I can understand that it's weird that the theme selector "does nothing" but we use a generic layout where the theme selector is displayed in all the examples for now.

"Product example": when screen is small (mobile for example), menu does not work. I click the button but nothing happens.

Good catch! I've created #39657 to fix it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants