Consistent naming conventions for theme-color unmapping

[roblevintennis]

Prerequisites

• I have searched for duplicate or closed feature requests
• I have read the contributing guidelines

Proposal

This should have no functional consequences but would perhaps improve the quality and readability.

It appears there are two approaches and I think the later below is clearer:

@each $color, $value in $theme-colors {
  .btn-#{$color} {
  ....

vs

@each $state in map-keys($theme-colors) {
  .list-group-item-#{$state} {
...

Put differently, I feel $state better expresses that these are in fact color mode states e.g. "dark" state or "light" state or "my-custom-mode" state; NOT a color per se.

I know this is a nitpick but definitely felt my cognitive effort wasted attempting to figure this out the first perusal of the code. Happy to help if folks agree here. Feel free to close if it's a stupid idea ;)

Motivation and context

• Less wasted cognitive effort to read the code
• Easier onboarding understanding for folks new to the codebase

[roblevintennis]

Realizing I actually misread the code and so this was just a "user error". Closing