Skip to content

Commit c7f6ecc

Browse files
authored
Apply suggestions from code review
1 parent 2e186c9 commit c7f6ecc

File tree

4 files changed

+5
-7
lines changed

4 files changed

+5
-7
lines changed

site/content/docs/5.3/customize/sass.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,8 @@ toc: true
99
Utilize our source Sass files to take advantage of variables, maps, mixins, and more.
1010

1111
{{< callout warning >}}
12-
**Sass deprecation warnings** are shown when compiling source sass files with the last versions of Dart Sass. This does not prevent compilation or usage. We are [working on a long-term fix]({{< param repo >}}/issues/40962) but in the meantime these deprecation notices can be ignored.
12+
Sass deprecation warnings are shown when compiling source Sass files with the latest versions of Dart Sass. This does not prevent compilation or usage of Bootstrap. We're [working on a long-term fix]({{< param repo >}}/issues/40962), but in the meantime these deprecation notices can be ignored.
1313
{{< /callout >}}
14-
1514
## File structure
1615

1716
Whenever possible, avoid modifying Bootstrap's core files. For Sass, that means creating your own stylesheet that imports Bootstrap so you can modify and extend it. Assuming you're using a package manager like npm, you'll have a file structure that looks like this:

site/content/docs/5.3/getting-started/parcel.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ With dependencies installed and our project folder ready for us to start coding,
110110
```
111111

112112

113-
3. ***Optional:*** Sass deprecation warnings are shown when compiling source Sass files with the last versions of Dart Sass. This does not prevent compilation or usage. We are [working on a long-term fix]({{< param repo >}}/issues/40962), in the meantime you can silence these warning by adding the following configuration in a `.sassrc.js` file in the root folder.
113+
3. **Optional:** You may see Sass deprecation warnings with the latest versions of Dart Sass. These can silenced by adding the following configuration in a `.sassrc.js` file in the root folder with the following:
114114

115115
```js
116116
module.exports = {

site/content/docs/5.3/getting-started/vite.md

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ With dependencies installed and our project folder ready for us to start coding,
9595
server: {
9696
port: 8080
9797
},
98-
// optional: silencing Sass deprecation warnings, see note below
98+
// Optional: Silence Sass deprecation warnings. See note below.
9999
css: {
100100
preprocessorOptions: {
101101
scss: {
@@ -111,8 +111,7 @@ With dependencies installed and our project folder ready for us to start coding,
111111
}
112112
```
113113

114-
***Note:*** *Sass deprecation warnings are shown when compiling source Sass files with the last versions of Dart Sass. This does not prevent compilation or usage. We are [working on a long-term fix]({{< param repo >}}/issues/40962), in the meantime the above config will suppress these warnings.*
115-
114+
**Note:** Sass deprecation warnings are shown when compiling source Sass files with the latest versions of Dart Sass. This does not prevent compilation or usage of Bootstrap. We're [working on a long-term fix]({{< param repo >}}/issues/40962), but in the meantime these deprecation notices can be ignored.
116115

117116
2. **Next we fill in `src/index.html`.** This is the HTML page Vite will load in the browser to utilize the bundled CSS and JS we'll add to it in later steps.
118117

site/content/docs/5.3/getting-started/webpack.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -225,7 +225,7 @@ Importing Bootstrap into Webpack requires the loaders we installed in the first
225225

226226
Here's a recap of why we need all these loaders. `style-loader` injects the CSS into a `<style>` element in the `<head>` of the HTML page, `css-loader` helps with using `@import` and `url()`, `postcss-loader` is required for Autoprefixer, and `sass-loader` allows us to use Sass.
227227

228-
***Note:*** *Sass deprecation warnings are shown when compiling source Sass files with the last versions of Dart Sass. This does not prevent compilation or usage. We are [working on a long-term fix]({{< param repo >}}/issues/40962), in the meantime the above config will suppress these warnings.*
228+
**Note:** Sass deprecation warnings are shown when compiling source Sass files with the latest versions of Dart Sass. This does not prevent compilation or usage of Bootstrap. We're [working on a long-term fix]({{< param repo >}}/issues/40962), but in the meantime these deprecation notices can be ignored.
229229

230230
2. **Now, let's import Bootstrap's CSS.** Add the following to `src/scss/styles.scss` to import all of Bootstrap's source Sass.
231231

0 commit comments

Comments
 (0)