Skip to content

Commit

Permalink
Fix #803 by unquoting all UTF8 escapes
Browse files Browse the repository at this point in the history
Work around Sass 3.4.x generating BOM that break IE10+
sass/sass#1395
  • Loading branch information
glebm committed Jan 17, 2015
1 parent bcf9fcd commit 443d5b4
Show file tree
Hide file tree
Showing 3 changed files with 266 additions and 259 deletions.
2 changes: 1 addition & 1 deletion assets/stylesheets/bootstrap/_breadcrumbs.scss
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
display: inline-block;

+ li:before {
content: "#{$breadcrumb-separator}\00a0"; // Unicode space added since inline-block means non-collapsing white-space
content: #{$breadcrumb-separator}\00a0; // Unicode space added since inline-block means non-collapsing white-space
padding: 0 5px;
color: $breadcrumb-color;
}
Expand Down
Loading

6 comments on commit 443d5b4

@drtz
Copy link

@drtz drtz commented on 443d5b4 Jan 19, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@glebm Was this tested in any browsers other than IE? None of the unquoted glyphicons seem to be working for me in Safari or Chrome after this change.

@glebm
Copy link
Member Author

@glebm glebm commented on 443d5b4 Jan 19, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@drtz Turns out not, I am having a look.

@glebm
Copy link
Member Author

@glebm glebm commented on 443d5b4 Jan 20, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hot-fixed in v3.3.2.1.

@nick250386
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even after downloading the latest version, I am still facing the issue where the icons are not rendering. There's one thing however I noticed that unicodes starting with 'e' or 'f' are the ones that are not getting rendered.
Any inputs on addressing this issue will be appreciated.

@glebm
Copy link
Member Author

@glebm glebm commented on 443d5b4 Nov 6, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nick250386 You may have to rake tmp:clear and restart the server.

@Pheonixashed
Copy link

@Pheonixashed Pheonixashed commented on 443d5b4 Nov 6, 2015 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.