Skip to content

Commit be0f05a

Browse files
committed
refactor: moved common GridView to core views
1 parent 2738971 commit be0f05a

File tree

5 files changed

+23
-33
lines changed

5 files changed

+23
-33
lines changed

app/clients/view.py

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
Card,
66
Column,
77
Container,
8-
GridView,
98
Icon,
109
ListTile,
1110
ResponsiveRow,
@@ -439,13 +438,7 @@ def __init__(self, params: TViewParams):
439438
)
440439
]
441440
)
442-
self.clients_container = GridView(
443-
expand=False,
444-
max_extent=540,
445-
child_aspect_ratio=1.0,
446-
spacing=dimens.SPACE_STD,
447-
run_spacing=dimens.SPACE_MD,
448-
)
441+
self.clients_container = views.THomeGrid()
449442
self.clients_to_display = {}
450443
self.contacts = {}
451444
self.editor = None

app/contacts/view.py

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
Card,
66
Column,
77
Container,
8-
GridView,
98
Icon,
109
ListTile,
1110
ResponsiveRow,
@@ -288,13 +287,7 @@ def __init__(self, params: TViewParams):
288287
)
289288
]
290289
)
291-
self.contacts_container = GridView(
292-
expand=False,
293-
max_extent=540,
294-
child_aspect_ratio=1.0,
295-
spacing=dimens.SPACE_STD,
296-
run_spacing=dimens.SPACE_MD,
297-
)
290+
self.contacts_container = views.THomeGrid()
298291
self.contacts_to_display = {}
299292
self.editor = None
300293

app/contracts/view.py

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
Column,
99
Container,
1010
ElevatedButton,
11-
GridView,
1211
Icon,
1312
IconButton,
1413
ListTile,
@@ -715,13 +714,7 @@ def __init__(self, params: TViewParams):
715714
)
716715
]
717716
)
718-
self.contracts_container = GridView(
719-
expand=False,
720-
max_extent=540,
721-
child_aspect_ratio=1.0,
722-
spacing=dimens.SPACE_STD,
723-
run_spacing=dimens.SPACE_MD,
724-
)
717+
self.contracts_container = views.THomeGrid()
725718
self.contracts_to_display = {}
726719
self.pop_up_handler = None
727720

app/core/views.py

Lines changed: 19 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
Dropdown,
1111
ElevatedButton,
1212
FilledButton,
13-
OutlinedButton,
13+
GridView,
1414
Icon,
1515
Image,
1616
PopupMenuButton,
@@ -858,3 +858,21 @@ def __init__(
858858
destinations=destinations,
859859
on_change=on_change,
860860
)
861+
862+
863+
class THomeGrid(GridView):
864+
"""Returns a grid view used in the home screen"""
865+
866+
def __init__(
867+
self,
868+
expand: bool = False,
869+
max_extent: int = 540,
870+
spacing: int = dimens.SPACE_STD,
871+
run_spacing: int = dimens.SPACE_STD,
872+
):
873+
return super().__init__(
874+
expand=expand,
875+
max_extent=max_extent,
876+
spacing=spacing,
877+
run_spacing=run_spacing,
878+
)

app/projects/view.py

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
Container,
1010
ElevatedButton,
1111
FontWeight,
12-
GridView,
1312
Icon,
1413
IconButton,
1514
ListTile,
@@ -629,13 +628,7 @@ def __init__(self, params):
629628
)
630629
]
631630
)
632-
self.projects_container = GridView(
633-
expand=False,
634-
max_extent=560,
635-
child_aspect_ratio=1.0,
636-
spacing=dimens.SPACE_STD,
637-
run_spacing=dimens.SPACE_MD,
638-
)
631+
self.projects_container = views.THomeGrid(max_extent=600)
639632
self.projects_to_display = {}
640633
self.dialog = None
641634

0 commit comments

Comments
 (0)