sqld: temp fix replica namespace doesnt exist #1770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarinPostma
approved these changes
Oct 3, 2024
haaawk
approved these changes
Oct 4, 2024
|
@haaawk @LucioFranco Please make sure there is an issue about the root cause bug too so we remember to fix it. |
|
I was hoping we could fix the root issue on the primary but this is a good start to mitigate the problem |
|
Maybe we should let the control plane eagerly create namespaces on replicas. That would make stuff easier for sqld |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there is a bug where a primary will report that a valid
namespace doesn't exist when it does and causes the replicate to
destroy the namespace locally. For now the temp solution is to
ignore this error (still log it) and don't destroy the local
namespace data on the replica. This trades off storage space for
returing 500s.