Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotations are lost with Microsoft.NETCore.App.Ref 3.1.0 #57

Closed
jnm2 opened this issue Dec 27, 2019 · 2 comments · Fixed by #62
Closed

Annotations are lost with Microsoft.NETCore.App.Ref 3.1.0 #57

jnm2 opened this issue Dec 27, 2019 · 2 comments · Fixed by #62

Comments

@jnm2
Copy link
Contributor

jnm2 commented Dec 27, 2019

string.IsNullOrEmpty no longer gets annotated when switching from 3.0.0 to 3.1.0.

  <PropertyGroup>
    <AnnotatedReferenceAssemblyVersion>3.1.0</AnnotatedReferenceAssemblyVersion>
  </PropertyGroup>
  <ItemGroup Condition="'$(TargetFramework)' != 'netcoreapp3.0' and '$(MSBuildProjectExtension)' == '.csproj'">
    <PackageReference Include="TunnelVisionLabs.ReferenceAssemblyAnnotator" Version="1.0.0-alpha.97" PrivateAssets="all" />
    <PackageDownload Include="Microsoft.NETCore.App.Ref" Version="[$(AnnotatedReferenceAssemblyVersion)]" />
  </ItemGroup>
@jnm2
Copy link
Contributor Author

jnm2 commented Dec 29, 2019

Skipping target "AnnotateReferenceAssemblies" because it has no outputs.

@jnm2
Copy link
Contributor Author

jnm2 commented Dec 29, 2019

The fix is to change netcoreapp3.0 to netcoreapp3.1 in this line:

<AnnotatedReferenceAssemblyDirectory Condition="'$(AnnotatedReferenceAssemblyDirectory)' == ''">$(NuGetPackageRoot)\microsoft.netcore.app.ref\$(AnnotatedReferenceAssemblyVersion)\ref\netcoreapp3.0\</AnnotatedReferenceAssemblyDirectory>

@sharwell How would you deal with generating the correct TFM to match the package version specified by AnnotatedReferenceAssemblyDirectory?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant