Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider GIT_AUTHOR_EMAIL/GIT_COMMITTER_EMAIL as current author/committer #72

Open
blueyed opened this issue Nov 29, 2022 · 3 comments
Open
Labels
upstream Blocked on upstream libgit2/git2rs

Comments

@blueyed
Copy link

blueyed commented Nov 29, 2022

When using $GIT_AUTHOR_EMAIL and $GIT_COMMITTER_EMAIL with something else than git config user.email, it will display a warning:

WARN Will not fix up past commits not authored by you, use --force to override, commit: …

I think that it should consider the env settings as the current owner - not sure if alone or additionally.

(FWIW, I am using the env variables to use different emails per projects.

It is easy enough to configure user.email there additionally, but that might require to do it with many sub-directories / projects for a company stored in a common ancestor dir, where setting the env can be done for all sub-directories more easily)

@tummychow
Copy link
Owner

would prefer to wait for upstream (libgit2/libgit2#3751) rather than hacking this in myself. i only accepted #22 because upstream explicitly declined to support it.

@tummychow tummychow added the upstream Blocked on upstream libgit2/git2rs label Apr 6, 2023
@petski
Copy link

petski commented Jul 18, 2024

FWIW, libgit2/libgit2#3751 is closed. The feature seems to be implemented.

@tummychow
Copy link
Owner

ah, that's good to know. ping this issue again when it's available in a git2-rs release and i'll bump for it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upstream Blocked on upstream libgit2/git2rs
Projects
None yet
Development

No branches or pull requests

3 participants