Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Link-Time Optimization (LTO) #119

Open
zamazan4ik opened this issue Sep 13, 2024 · 0 comments
Open

Enable Link-Time Optimization (LTO) #119

zamazan4ik opened this issue Sep 13, 2024 · 0 comments
Labels
gh actions Release infrastructure for this repo good first issue Good for newcomers

Comments

@zamazan4ik
Copy link

Hi!

I noticed that in the Cargo.toml file Link-Time Optimization (LTO) for the project is not enabled. I suggest switching it on since it will reduce the binary size (always a good thing to have) and will likely improve the application's performance a bit (in this case, it's not critical at all but anyway).

I suggest enabling LTO only for the Release builds so as not to sacrifice the developers' experience while working on the project since LTO consumes an additional amount of time to finish the compilation routine. If you think that a regular Release build should not be affected by such a change as well, then I suggest adding an additional dist or release-lto profile where additionally to regular release optimizations LTO also will be added. Such a change simplifies life for maintainers and others interested in the project persons who want to build the most performant version of the application. Using ThinLTO also should help. If we enable it on the Cargo profile level, users, who install the application with cargo install, will get the LTO-optimized version "automatically".

Thank you.

P.S. It's more like an improvement idea rather than a bug. I created the issue just because the Discussions are disabled for the repo for now.

@tummychow tummychow added good first issue Good for newcomers gh actions Release infrastructure for this repo labels Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gh actions Release infrastructure for this repo good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants