fix linter

Author: rotmanjanez

internal/clients/http_client.go

@@ -16,7 +16,6 @@ import (
 	"github.com/tum-zulip/go-zulip/zulip"
 )
 
-//nolint:funlen
 func buildHTTPClient(
 	baseClient *http.Client,
 	params *zulip.RC,
@@ -45,7 +44,10 @@ func buildHTTPClient(
 
 	if t, ok := transport.(*http.Transport); ok {
 		cp := t.Clone()
-		configureTransportTLS(cp, params, logger, warnOnInsecureTLS)
+		err := configureTransportTLS(cp, params, logger, warnOnInsecureTLS)
+		if err != nil {
+			return nil, "", err
+		}
 		transport = cp
 	} else {
 		if params.CertBundle != "" || params.ClientCert != "" {
@@ -71,7 +73,12 @@ func buildHTTPClient(
 	return &clientCopy, userAgent, nil
 }
 
-func configureTransportTLS(transport *http.Transport, params *zulip.RC, logger *slog.Logger, warnOnInsecureTLS bool) error {
+func configureTransportTLS(
+	transport *http.Transport,
+	params *zulip.RC,
+	logger *slog.Logger,
+	warnOnInsecureTLS bool,
+) error {
 	if transport.TLSClientConfig == nil {
 		transport.TLSClientConfig = &tls.Config{
 			MinVersion: tls.VersionTLS12,
@@ -162,6 +169,7 @@ func buildUserAgent(clientName string) string {
 	vendor, version := detectPlatform()
 	return fmt.Sprintf("%s (%s; %s)", clientName, vendor, version)
 }
+
 func normalizePath(pathStr string) (string, error) {
 	expanded := os.ExpandEnv(pathStr)
 	if strings.HasPrefix(expanded, "~") {

internal/test_utils/utils.go

@@ -195,7 +195,6 @@ func getTestClient(t *testing.T, username string) (*z.RC, client.Client) {
 		client.SkipWarnOnInsecureTLS(),
 		client.EnableStatistics(),
 		client.WithHTTPClient(newHTTPClientForTestSite()))
-
 	if err != nil {
 		t.Fatalf("Failed to create z.client: %v", err)
 	}
@@ -204,15 +203,18 @@ func getTestClient(t *testing.T, username string) (*z.RC, client.Client) {
 }
 
 func newHTTPClientForTestSite() *http.Client {
+	const timeout = 30 * time.Second
+	const keepAlive = 30 * time.Second
+
 	baseTransport, ok := http.DefaultTransport.(*http.Transport)
 	if !ok {
 		panic("default transport is not an *http.Transport")
 	}
 
 	transport := baseTransport.Clone()
 	dialer := &net.Dialer{
-		Timeout:   30 * time.Second,
-		KeepAlive: 30 * time.Second,
+		Timeout:   timeout,
+		KeepAlive: keepAlive,
 	}
 
 	transport.DialContext = func(ctx context.Context, network, address string) (net.Conn, error) {
@@ -240,6 +242,7 @@ type UserInfo struct {
 	UserID int    `json:"user_id"`
 }
 
+//nolint:funlen,gocognit,nolintlint
 func fetchUserInfo(t *testing.T, username string) UserInfo {
 	t.Helper()