From 0c3fe642e77f7d590499ceea85e3716219b7dddf Mon Sep 17 00:00:00 2001 From: Thomas David Dickinson Date: Fri, 11 Dec 2020 17:36:13 +0800 Subject: [PATCH] User Array.push() instead of spread/concat --- src/protocol/requests/fetch/v4/decodeMessages.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/protocol/requests/fetch/v4/decodeMessages.js b/src/protocol/requests/fetch/v4/decodeMessages.js index 951d0e146..abae0f515 100644 --- a/src/protocol/requests/fetch/v4/decodeMessages.js +++ b/src/protocol/requests/fetch/v4/decodeMessages.js @@ -20,12 +20,12 @@ const decodeMessages = async decoder => { const magicByte = messagesBuffer.slice(MAGIC_OFFSET).readInt8(0) if (magicByte === MAGIC_BYTE) { - let records = [] + const records = [] while (messagesDecoder.canReadBytes(RECORD_BATCH_OVERHEAD)) { try { const recordBatch = await RecordBatchDecoder(messagesDecoder) - records = [...records, ...recordBatch.records] + records.push(...recordBatch.records) } catch (e) { // The tail of the record batches can have incomplete records // due to how maxBytes works. See https://cwiki.apache.org/confluence/display/KAFKA/A+Guide+To+The+Kafka+Protocol#AGuideToTheKafkaProtocol-FetchAPI