Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement idea: documentation around advanced pyTMD.compute params #354

Open
robbibt opened this issue Oct 29, 2024 · 1 comment
Open

Comments

@robbibt
Copy link
Contributor

robbibt commented Oct 29, 2024

I've been seeing some great new functionality added to pyTMD recently, particularly around the following pyTMD.compute.* params:

        CORRECTIONS: str | None = None,
        INFER_MINOR: bool = True,
        MINOR_CONSTITUENTS: list | None = None,
        APPEND_NODE: bool = False,
        APPLY_FLEXURE: bool = False,

However, as someone without a tide science backgorund, I don't have a great understanding of what these features do, and so am unsure of whether I should be simply using the defaults or turn on any of these features to improve the accuracy of my tide modelling.

It would be fantastic to have a page in the docs that describes these features, and provides some guidance on the advantages/limitations/reasons for using each of them for different applications. For example, important things to consider or keep in mind so that users can make an informed decision based on their use case. 🙂 I could imagine this perhaps living somethere like this:

https://pytmd.readthedocs.io/en/latest/getting_started/Getting-Started.html#programs
https://pytmd.readthedocs.io/en/latest/getting_started/Background.html

@robbibt robbibt changed the title Enhancement proposal: documentation around advanced pyTMD.compute params Enhancement idea: documentation around advanced pyTMD.compute params Oct 30, 2024
@tsutterley tsutterley self-assigned this Oct 30, 2024
@tsutterley
Copy link
Owner

Great great point. Definitely need to expand the documentation particularly after exposing more of these parameters. On the to-do list! Thanks @robbibt!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants