Add new nullable functions that support null values in jimp
#17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serd223
changed the title
nullable functions that support null valuesnullable functions that support null values in jimp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to communicate the difference between an error and encountering
null, I introduced aJimp_Resultenumeration. Since JIMP_ERR is 0, users can still use theif (!jimp_xxx(&jimp, &xx) return false;paradigm. If they want to handle null cases explicitly, they can introduce that complexity when they desire. Since handling null cases, in my opinion, is very application specific I think the library user should be expected to handle that andjimpshould only alert the user when a null value is found.