Skip to content

Fix type annotations, add docstrings, rename unused count variables #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix type annotations, add docstrings, rename unused count variables #1

wants to merge 4 commits into from

Conversation

CoolCat467
Copy link

@CoolCat467 CoolCat467 commented Oct 15, 2022 •
edited
Loading

This PR makes the following changes:

  • Adds a few missing type annotations so mypy can work well
  • Aligns method_access_flags by comma
  • Adds documentation strings to functions and the module
  • Renames unused count variables to _

This is a cool project and I am excited to see how this will develop in the future. Thank you for your time. Stay safe!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@CoolCat467