Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conform to DialogTrigger in all Items and Groups (#23) #23

Merged
merged 2 commits into from
Feb 12, 2022

Conversation

tschob
Copy link
Owner

@tschob tschob commented Feb 12, 2022

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Feb 12, 2022

Codecov Report

Merging #23 (957ca25) into main (91497b3) will increase coverage by 0.01%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #23      +/-   ##
==========================================
+ Coverage   76.65%   76.66%   +0.01%     
==========================================
  Files          64       64              
  Lines        1863     1864       +1     
  Branches      722      723       +1     
==========================================
+ Hits         1428     1429       +1     
  Misses        422      422              
  Partials       13       13              
Flag Coverage Δ
QAMenu 97.12% <100.00%> (+<0.01%) ⬆️
QAMenuUIKit 61.29% <50.00%> (ø)
QAMenuUtils 94.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
Sources/QAMenu/Public/Data Structure/Group.swift 100.00% <ø> (ø)
.../QAMenu/Public/Data Structure/Items/BoolItem.swift 47.82% <ø> (-2.18%) ⬇️
...s/QAMenuUIKit/Internal/UI/PaneViewController.swift 40.28% <50.00%> (ø)
Sources/QAMenu/Public/Data Structure/Item.swift 100.00% <100.00%> (ø)
...urces/QAMenu/Public/Data Structure/ItemGroup.swift 100.00% <100.00%> (ø)
...ces/QAMenu/Public/Data Structure/PickerGroup.swift 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91497b3...957ca25. Read the comment docs.

@tschob tschob merged commit d188ba0 into main Feb 12, 2022
@tschob tschob deleted the feature/dialogtrigger branch April 18, 2022 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants