binding: mock readFileSync #378
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Whereas it was working fine on Node Based on the changelog at https://github.com/nodejs/node/blob/main/doc/changelogs/CHANGELOG_V20.md#2023-09-28-version-2080-current-ruyadorno , I am guessing it's some of the changes such as nodejs/node#49593 or nodejs/node#49691 |
|
Closing this since there are additional breaking change in Node.js v20.8.0, and we are now moving away from mock-fs in favor of temporary mock directories. (backstage/backstage#20436 has some extra context in case anyone is interested) |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for #377
Most of it is explained in the comment, but to reiterate: we can mock the optimized
readFileSyncmethod introduced in Node v20 by calling the originalreadFileSyncbut bypassing the optimization by calling.toString('utf8')manually afterwards instead.I figured it's safe to ignore the flag since it's just mocked reads anyway, let's me know if that needs a fix.