feat(ecmascript): Make RegExp always match in unicode mode (#832)

Author: aapoalas

nova_vm/src/ecmascript/builtins/regexp/data.rs

@@ -135,7 +135,7 @@ impl<'a> RegExpHeapData<'a> {
         RegexBuilder::new(pattern)
             .dot_matches_new_line((flags & RegExpFlags::M).bits() > 0)
             .case_insensitive((flags & RegExpFlags::I).bits() > 0)
-            .unicode((flags & (RegExpFlags::U | RegExpFlags::V)).bits() > 0)
+            .unicode(true)
             .dot_matches_new_line((flags & RegExpFlags::S).bits() > 0)
             .octal(false) // TODO: !strict
             .build()

nova_vm/src/ecmascript/execution/environments.rs

@@ -1119,9 +1119,6 @@ impl Environments {
         &self,
         index: DeclarativeEnvironment,
     ) -> &DeclarativeEnvironmentRecord {
-        if self.declarative.get(index.into_index()).is_none() {
-            eprintln!("env: {index:?}");
-        }
         self.declarative
             .get(index.into_index())
             .expect("DeclarativeEnvironment did not match to any vector index")

tests/expectations.json

@@ -1826,7 +1826,6 @@
   "built-ins/Reflect/ownKeys/return-on-corresponding-order-large-index.js": "FAIL",
   "built-ins/RegExp/S15.10.2.10_A2.1_T1.js": "FAIL",
   "built-ins/RegExp/S15.10.2.10_A2.1_T2.js": "FAIL",
-  "built-ins/RegExp/S15.10.2.10_A3.1_T1.js": "FAIL",
   "built-ins/RegExp/S15.10.2.10_A5.1_T1.js": "FAIL",
   "built-ins/RegExp/S15.10.2.11_A1_T1.js": "FAIL",
   "built-ins/RegExp/S15.10.2.11_A1_T4.js": "FAIL",
@@ -2452,7 +2451,7 @@
   "built-ins/String/prototype/localeCompare/15.5.4.9_CE.js": "FAIL",
   "built-ins/String/prototype/match/duplicate-named-groups-properties.js": "FAIL",
   "built-ins/String/prototype/match/duplicate-named-indices-groups-properties.js": "FAIL",
-  "built-ins/String/prototype/match/regexp-prototype-match-v-u-flag.js": "CRASH",
+  "built-ins/String/prototype/match/regexp-prototype-match-v-u-flag.js": "FAIL",
   "built-ins/String/prototype/matchAll/regexp-prototype-matchAll-v-u-flag.js": "FAIL",
   "built-ins/String/prototype/replace/S15.5.4.11_A5_T1.js": "FAIL",
   "built-ins/String/prototype/replace/regexp-capture-by-index.js": "FAIL",
@@ -7633,6 +7632,7 @@
   "language/literals/regexp/named-groups/invalid-unterminated-groupspecifier-u.js": "FAIL",
   "language/literals/regexp/named-groups/invalid-unterminated-groupspecifier.js": "FAIL",
   "language/literals/regexp/u-astral.js": "FAIL",
+  "language/literals/regexp/u-case-mapping.js": "FAIL",
   "language/literals/regexp/u-invalid-class-escape.js": "FAIL",
   "language/literals/regexp/u-invalid-extended-pattern-char.js": "FAIL",
   "language/literals/regexp/u-invalid-identity-escape.js": "FAIL",
@@ -8353,7 +8353,6 @@
   "staging/sm/RegExp/exec.js": "FAIL",
   "staging/sm/RegExp/flags-param-handling.js": "FAIL",
   "staging/sm/RegExp/flags.js": "FAIL",
-  "staging/sm/RegExp/ignoreCase-multiple.js": "FAIL",
   "staging/sm/RegExp/ignoreCase-non-latin1-to-latin1.js": "FAIL",
   "staging/sm/RegExp/instance-property-storage-introspection.js": "FAIL",
   "staging/sm/RegExp/lastIndex-exec.js": "FAIL",

tests/metrics.json

@@ -1,8 +1,8 @@
 {
   "results": {
-    "crash": 106,
+    "crash": 105,
     "fail": 8528,
-    "pass": 38611,
+    "pass": 38612,
     "skip": 3310,
     "timeout": 9,
     "unresolved": 30