Skip to content

Commit 82a6aed

Browse files
committed
Remove commented out code
1 parent aaae4b8 commit 82a6aed

File tree

4 files changed

+26
-334
lines changed

4 files changed

+26
-334
lines changed

js/src/Arrow.dom.ts

Lines changed: 0 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -56,39 +56,16 @@ export {
5656
FixedSizeList,
5757
Map_, MapRow,
5858
Table,
59-
// Column,
6059
Schema, Field,
6160
Visitor,
6261
Vector, makeVector, vectorFromArray,
63-
// BaseVector,
64-
// BinaryVector,
65-
// BoolVector,
66-
// Chunked,
67-
// DateVector, DateDayVector, DateMillisecondVector,
68-
// DecimalVector,
69-
// DictionaryVector,
70-
// FixedSizeBinaryVector,
71-
// FixedSizeListVector,
72-
// FloatVector, Float16Vector, Float32Vector, Float64Vector,
73-
// IntervalVector, IntervalDayTimeVector, IntervalYearMonthVector,
74-
// IntVector, Int8Vector, Int16Vector, Int32Vector, Int64Vector, Uint8Vector, Uint16Vector, Uint32Vector, Uint64Vector,
75-
// ListVector,
76-
// MapVector,
77-
// NullVector,
78-
// StructVector,
79-
// TimestampVector, TimestampSecondVector, TimestampMillisecondVector, TimestampMicrosecondVector, TimestampNanosecondVector,
80-
// TimeVector, TimeSecondVector, TimeMillisecondVector, TimeMicrosecondVector, TimeNanosecondVector,
81-
// UnionVector, DenseUnionVector, SparseUnionVector,
82-
// Utf8Vector,
8362
ByteStream, AsyncByteStream, AsyncByteQueue, ReadableSource, WritableSink,
8463
RecordBatchReader, RecordBatchFileReader, RecordBatchStreamReader, AsyncRecordBatchFileReader, AsyncRecordBatchStreamReader,
8564
RecordBatchWriter, RecordBatchFileWriter, RecordBatchStreamWriter, RecordBatchJSONWriter,
8665
MessageReader, AsyncMessageReader, JSONMessageReader,
8766
Message,
8867
RecordBatch,
8968
ArrowJSONLike, FileHandle, Readable, Writable, ReadableWritable, ReadableDOMStreamOptions,
90-
// DataFrame, FilteredDataFrame, CountByResult, BindFunc, NextFunc,
91-
// predicate,
9269
util,
9370
Builder,
9471
BinaryBuilder,

js/src/Arrow.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -88,18 +88,15 @@ export { MessageReader, AsyncMessageReader, JSONMessageReader } from './ipc/mess
8888
export { Message } from './ipc/metadata/message';
8989
export { RecordBatch } from './recordbatch';
9090
export { ArrowJSONLike, FileHandle, Readable, Writable, ReadableWritable, ReadableDOMStreamOptions } from './io/interfaces';
91-
// export { DataFrame, FilteredDataFrame, CountByResult, BindFunc, NextFunc } from './compute/dataframe';
9291

9392
import * as util_bn_ from './util/bn';
9493
import * as util_int_ from './util/int';
9594
import * as util_bit_ from './util/bit';
9695
import * as util_math_ from './util/math';
9796
import * as util_buffer_ from './util/buffer';
9897
import * as util_vector_ from './util/vector';
99-
// import * as predicate from './compute/predicate';
10098
import { compareSchemas, compareFields, compareTypes } from './visitor/typecomparator';
10199

102-
// export { predicate };
103100
/** @ignore */
104101
export const util = {
105102
...util_bn_,

js/src/util/bn.ts

Lines changed: 26 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -36,10 +36,10 @@ function BigNum(this: any, x: any, ...xs: any) {
3636
}
3737

3838
BigNum.prototype[isArrowBigNumSymbol] = true;
39-
BigNum.prototype.toJSON = function<T extends BN<BigNumArray>>(this: T) { return `"${bignumToString(this)}"`; };
40-
BigNum.prototype.valueOf = function<T extends BN<BigNumArray>>(this: T) { return bignumToNumber(this); };
41-
BigNum.prototype.toString = function<T extends BN<BigNumArray>>(this: T) { return bignumToString(this); };
42-
BigNum.prototype[Symbol.toPrimitive] = function<T extends BN<BigNumArray>>(this: T, hint: 'string' | 'number' | 'default' = 'default') {
39+
BigNum.prototype.toJSON = function <T extends BN<BigNumArray>>(this: T) { return `"${bignumToString(this)}"`; };
40+
BigNum.prototype.valueOf = function <T extends BN<BigNumArray>>(this: T) { return bignumToNumber(this); };
41+
BigNum.prototype.toString = function <T extends BN<BigNumArray>>(this: T) { return bignumToString(this); };
42+
BigNum.prototype[Symbol.toPrimitive] = function <T extends BN<BigNumArray>>(this: T, hint: 'string' | 'number' | 'default' = 'default') {
4343
switch (hint) {
4444
case 'number': return bignumToNumber(this);
4545
case 'string': return bignumToString(this);
@@ -53,7 +53,7 @@ BigNum.prototype[Symbol.toPrimitive] = function<T extends BN<BigNumArray>>(this:
5353
type TypedArrayConstructorArgs =
5454
[number | void] |
5555
[Iterable<number> | Iterable<bigint>] |
56-
[ArrayBufferLike, number | void, number | void] ;
56+
[ArrayBufferLike, number | void, number | void];
5757

5858
/** @ignore */
5959
function SignedBigNum(this: any, ...args: TypedArrayConstructorArgs) { return BigNum.apply(this, args); }
@@ -62,12 +62,12 @@ function UnsignedBigNum(this: any, ...args: TypedArrayConstructorArgs) { return
6262
/** @ignore */
6363
function DecimalBigNum(this: any, ...args: TypedArrayConstructorArgs) { return BigNum.apply(this, args); }
6464

65-
Object.setPrototypeOf(SignedBigNum.prototype, Object.create(Int32Array.prototype));
65+
Object.setPrototypeOf(SignedBigNum.prototype, Object.create(Int32Array.prototype));
6666
Object.setPrototypeOf(UnsignedBigNum.prototype, Object.create(Uint32Array.prototype));
67-
Object.setPrototypeOf(DecimalBigNum.prototype, Object.create(Uint32Array.prototype));
68-
Object.assign(SignedBigNum.prototype, BigNum.prototype, { 'constructor': SignedBigNum, 'signed': true, 'TypedArray': Int32Array, 'BigIntArray': BigInt64Array });
67+
Object.setPrototypeOf(DecimalBigNum.prototype, Object.create(Uint32Array.prototype));
68+
Object.assign(SignedBigNum.prototype, BigNum.prototype, { 'constructor': SignedBigNum, 'signed': true, 'TypedArray': Int32Array, 'BigIntArray': BigInt64Array });
6969
Object.assign(UnsignedBigNum.prototype, BigNum.prototype, { 'constructor': UnsignedBigNum, 'signed': false, 'TypedArray': Uint32Array, 'BigIntArray': BigUint64Array });
70-
Object.assign(DecimalBigNum.prototype, BigNum.prototype, { 'constructor': DecimalBigNum, 'signed': true, 'TypedArray': Uint32Array, 'BigIntArray': BigUint64Array });
70+
Object.assign(DecimalBigNum.prototype, BigNum.prototype, { 'constructor': DecimalBigNum, 'signed': true, 'TypedArray': Uint32Array, 'BigIntArray': BigUint64Array });
7171

7272
/** @ignore */
7373
function bignumToNumber<T extends BN<BigNumArray>>(bn: T) {
@@ -92,7 +92,7 @@ export let bignumToBigInt: { <T extends BN<BigNumArray>>(a: T): bigint };
9292

9393
if (!BigIntAvailable) {
9494
bignumToString = decimalToString;
95-
bignumToBigInt = <any> bignumToString;
95+
bignumToBigInt = <any>bignumToString;
9696
} else {
9797
bignumToBigInt = (<T extends BN<BigNumArray>>(a: T) => a.byteLength === 8 ? new a['BigIntArray'](a.buffer, a.byteOffset, 1)[0] : <any>decimalToString(a));
9898
bignumToString = (<T extends BN<BigNumArray>>(a: T) => a.byteLength === 8 ? `${new a['BigIntArray'](a.buffer, a.byteOffset, 1)[0]}` : decimalToString(a));
@@ -123,32 +123,32 @@ export class BN<T extends BigNumArray> {
123123
/** @nocollapse */
124124
public static new<T extends BigNumArray>(num: T, isSigned?: boolean): (T & BN<T>) {
125125
switch (isSigned) {
126-
case true: return new (<any> SignedBigNum)(num) as (T & BN<T>);
127-
case false: return new (<any> UnsignedBigNum)(num) as (T & BN<T>);
126+
case true: return new (<any>SignedBigNum)(num) as (T & BN<T>);
127+
case false: return new (<any>UnsignedBigNum)(num) as (T & BN<T>);
128128
}
129129
switch (num.constructor) {
130130
case Int8Array:
131131
case Int16Array:
132132
case Int32Array:
133133
case BigInt64Array:
134-
return new (<any> SignedBigNum)(num) as (T & BN<T>);
134+
return new (<any>SignedBigNum)(num) as (T & BN<T>);
135135
}
136136
if (num.byteLength === 16) {
137-
return new (<any> DecimalBigNum)(num) as (T & BN<T>);
137+
return new (<any>DecimalBigNum)(num) as (T & BN<T>);
138138
}
139-
return new (<any> UnsignedBigNum)(num) as (T & BN<T>);
139+
return new (<any>UnsignedBigNum)(num) as (T & BN<T>);
140140
}
141141
/** @nocollapse */
142142
public static signed<T extends IntArray>(num: T): (T & BN<T>) {
143-
return new (<any> SignedBigNum)(num) as (T & BN<T>);
143+
return new (<any>SignedBigNum)(num) as (T & BN<T>);
144144
}
145145
/** @nocollapse */
146146
public static unsigned<T extends UintArray>(num: T): (T & BN<T>) {
147-
return new (<any> UnsignedBigNum)(num) as (T & BN<T>);
147+
return new (<any>UnsignedBigNum)(num) as (T & BN<T>);
148148
}
149149
/** @nocollapse */
150150
public static decimal<T extends UintArray>(num: T): (T & BN<T>) {
151-
return new (<any> DecimalBigNum)(num) as (T & BN<T>);
151+
return new (<any>DecimalBigNum)(num) as (T & BN<T>);
152152
}
153153
constructor(num: T, isSigned?: boolean) {
154154
return BN.new(num, isSigned) as any;
@@ -158,20 +158,20 @@ export class BN<T extends BigNumArray> {
158158
/** @ignore */
159159
export interface BN<T extends BigNumArray> extends TypedArrayLike<T> {
160160

161-
new<T extends ArrayBufferViewInput>(buffer: T, signed?: boolean): T;
161+
new <T extends ArrayBufferViewInput>(buffer: T, signed?: boolean): T;
162162

163163
readonly signed: boolean;
164164
readonly TypedArray: TypedArrayConstructor<TypedArray>;
165165
readonly BigIntArray: BigIntArrayConstructor<BigIntArray>;
166166

167167
[Symbol.toStringTag]:
168-
'Int8Array' |
169-
'Int16Array' |
170-
'Int32Array' |
171-
'Uint8Array' |
172-
'Uint16Array' |
173-
'Uint32Array' |
174-
'Uint8ClampedArray';
168+
'Int8Array' |
169+
'Int16Array' |
170+
'Int32Array' |
171+
'Uint8Array' |
172+
'Uint16Array' |
173+
'Uint32Array' |
174+
'Uint8ClampedArray';
175175

176176
/**
177177
* Convert the bytes to their (positive) decimal representation for printing

0 commit comments

Comments
 (0)