tsan fix and update ci to upload logs

Author: trvon

.github/workflows/ci.yml

@@ -121,7 +121,13 @@ jobs:
         run: meson compile -C build_tsan
 
       - name: Test
-        run: meson test -C build_tsan
+        run: meson test -C build_tsan --print-errorlogs --verbose
+      - name: Upload tsan test logs
+        if: always()
+        uses: actions/upload-artifact@v4
+        with:
+          name: tsan-test-logs
+          path: build_tsan/meson-logs/testlog.txt
 
   # =============================================================================
   # Linux Benchmarks

include/sqlite-vec-cpp/index/hnsw.hpp

@@ -812,20 +812,20 @@ template <concepts::VectorElement StorageT, typename MetricT> class HNSWIndex {
     /// This improves search quality by not traversing to dead-ends
     /// Call after batch deletions but before search
     void isolate_deleted() {
+        std::unique_lock nodes_lock(nodes_mutex_);
         std::shared_lock deleted_lock(deleted_mutex_);
         if (deleted_ids_.empty())
             return;
 
-        std::unique_lock nodes_lock(nodes_mutex_);
         for (auto& [id, node] : nodes_) {
             if (is_deleted_unlocked(id))
                 continue;
 
             // Remove edges to deleted nodes at each layer
             for (size_t layer = 0; layer < node.edges.size(); ++layer) {
                 auto& layer_edges = node.edges[layer];
-                std::erase_if(layer_edges,
-                              [this](size_t neighbor) { return is_deleted(neighbor); });
+                std::erase_if(
+                    layer_edges, [this](size_t neighbor) { return is_deleted_unlocked(neighbor); });
             }
         }
     }