Adds API to import encoded private keys #4357
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary size comparison➡️ aarch64-apple-ios: 13.93 MB ➡️ aarch64-apple-ios-sim: 13.93 MB ➡️ aarch64-linux-android: 18.36 MB ➡️ armv7-linux-androideabi: 15.37 MB ➡️ wasm32-unknown-emscripten: 13.07 MB |
satoshiotomakan
requested changes
Apr 10, 2025
enriquesouza
pushed a commit
to enriquesouza/wallet-core
that referenced
this pull request
Apr 18, 2025
* Adds API to import encoded private keys * Adds solana base58 decoding as well * Supports 64 byte solana key import and moves Crc * Adds API to retrieve encoded key * Adds APIs and Tests based on the discussion * Addresses review comments * Addresses review comments * Updates Android test
zkrypt-crossbar
pushed a commit
to Cramiumlabs/wallet-core
that referenced
this pull request
Jun 15, 2025
* Adds API to import encoded private keys * Adds solana base58 decoding as well * Supports 64 byte solana key import and moves Crc * Adds API to retrieve encoded key * Adds APIs and Tests based on the discussion * Addresses review comments * Addresses review comments * Updates Android test
zkrypt-crossbar
pushed a commit
to Cramiumlabs/wallet-core
that referenced
this pull request
Jun 21, 2025
* Adds API to import encoded private keys * Adds solana base58 decoding as well * Supports 64 byte solana key import and moves Crc * Adds API to retrieve encoded key * Adds APIs and Tests based on the discussion * Addresses review comments * Addresses review comments * Updates Android test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds APIs to allow each coin type to specify a decoder for its private key. Currently, it fixes an issue in importing Base32 encoded keys for Stellar.
How to test
Added Tests
Types of changes
New feature (non-breaking change which adds functionality)
Checklist
If you're adding a new blockchain