Fix: 30+ typos folder rust
#4328
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sajjon
force-pushed
the
chore/fix_typos_folder_rust
branch
from
37c3b93 to
36fb68d
Compare
satoshiotomakan
requested changes
Mar 24, 2025
There was a problem hiding this comment.
Hi @Sajjon, thanks for opening the PR! Can you please revert _typos.toml file?
Sajjon
force-pushed
the
chore/fix_typos_folder_rust
branch
from
36fb68d to
4b74112
Compare
Sajjon
force-pushed
the
chore/fix_typos_folder_rust
branch
from
4b74112 to
61d0c0f
Compare
|
@satoshiotomakan Reverted :) |
enriquesouza
pushed a commit
to enriquesouza/wallet-core
that referenced
this pull request
Apr 18, 2025
Co-authored-by: Sergei Boiko <127754187+satoshiotomakan@users.noreply.github.com>
zkrypt-crossbar
pushed a commit
to Cramiumlabs/wallet-core
that referenced
this pull request
Jun 15, 2025
Co-authored-by: Sergei Boiko <127754187+satoshiotomakan@users.noreply.github.com>
zkrypt-crossbar
pushed a commit
to Cramiumlabs/wallet-core
that referenced
this pull request
Jun 21, 2025
Co-authored-by: Sergei Boiko <127754187+satoshiotomakan@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixing typos using CLI tool
typos- we can add it as a pre-commit hook later if you like it.Added a config file
_typos.tomlwhich is used to configure the CLI, e.g. filter out some false positives (such as addresses, signatures and otherwise non words such as hex and base64/base58 strings).Running typos in the whole repo results in soo many typos that the PR would be unweildy to review, so I've started with only the
rustfolder first.Tip
Let me know if you want me to split this into several PRs.
Let me know if you welcome me proceeding with the rest of the projects (no only
rustfolder).Note
The
rustfolder (and I would assume the whole projects) completely mixes between American 🇺🇸 English and British 🇬🇧 English.Perhaps code owners can agree on a preferred locale and I can do a follow up PR which corrects spelling to that locale.
How to test
No public API should have been affected.
Types of changes
Most typos were in comments, a few local variables and very few methods.
Checklist