dkimf_db_walk: explicitly treat DKIMF_DB_MEMCACHE as unsupported db type. #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ype. This saves incorrect usage of DKIMF_DB_MEMCACHE from assertion failure addressing to unknown DB type error, although it still need that caller should handle the error properly.
* opendkim/opendkim-db.c, opendkim/opendkim-db.h (dkimf_can_db_walk): New.
does not support db walk operation * opendkim/opendkim.c (dkimf_config_load): As above
futatuki
force-pushed
the
db_walk_avoid_abort
branch
from
80228d5
to
565d38c
Compare
Now it check if the db supports |
Add assertion db should not be NULL
futatuki
added a commit
to futatuki/OpenDKIM
that referenced
this pull request
Oct 7, 2024
…id_abort This saves incorrect usage of DKIMF_DB_TYPE_MEMCACHE from assertion failure addressing to unknown DB type error, and avoid execute verification of signing table on loading configurations. (See the issue trusteddomainproject#218) trusteddomainproject#218 trusteddomainproject#219
futatuki
added a commit
to futatuki/OpenDKIM
that referenced
this pull request
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This saves incorrect usage of DKIMF_DB_MEMCACHE from assertion failure addressing to unknown DB type error, although it still need that caller should handle the error properly. (see issue #218)