Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

Fix: Bump maxBuffer for Docker solc compilations #3139

Merged
merged 1 commit into from
Jul 2, 2020
Merged

Conversation

CruzMolina
Copy link
Contributor

@CruzMolina CruzMolina commented Jul 1, 2020

Resolves #3140.

@chmanie
Copy link
Contributor

chmanie commented Jul 2, 2020

I found that 20MB should suffice (but 100 is probably on the safe side?). I'm not sure what negative implications a high number might have here

@CruzMolina
Copy link
Contributor Author

@chmanie FWIW, apparently node 10 and lower's default maxBuffer for execSync was set to Infinity 👀: nodejs/node#23027 (comment)

I think 100 should be ok, but would be fine with 20 or 50.

@fainashalts
Copy link
Contributor

👍 LGTM!

@CruzMolina CruzMolina merged commit 486e227 into develop Jul 2, 2020
@CruzMolina CruzMolina deleted the bumpMaxBuffer branch July 2, 2020 16:53
coeniebeyers added a commit to Adhara-Tech/solidity-coverage that referenced this pull request Aug 3, 2020
marsdalesa pushed a commit to Adhara-Tech/solidity-coverage that referenced this pull request Apr 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Colony job broken
3 participants